From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YnwzA-0002Ro-8a for qemu-devel@nongnu.org; Thu, 30 Apr 2015 18:31:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ynwz6-000784-Vx for qemu-devel@nongnu.org; Thu, 30 Apr 2015 18:31:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ynwz6-00077w-Mk for qemu-devel@nongnu.org; Thu, 30 Apr 2015 18:31:08 -0400 Message-ID: <5542ACFF.6050002@redhat.com> Date: Thu, 30 Apr 2015 16:30:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428775783-18082-1-git-send-email-eblake@redhat.com> <1428775783-18082-4-git-send-email-eblake@redhat.com> <87y4lb6uls.fsf@blackfin.pond.sub.org> <5540F902.3090200@redhat.com> In-Reply-To: <5540F902.3090200@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fb9cKSMwBosrmeweoEecB6ohL6PNlqnJ1" Subject: Re: [Qemu-devel] [PATCH v2 3/4] qapi: Correctly handle downstream extensions in more locations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fb9cKSMwBosrmeweoEecB6ohL6PNlqnJ1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/29/2015 09:30 AM, Eric Blake wrote: > On 04/29/2015 05:29 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Now that c_var() handles '.' in downstream extension names, fix >>> the generator to support such names as additional types, enums, >>> members within an enum, branches of a union or alternate, and >>> in arrays. >>> >>> >>> def generate_visit_struct_fields(name, field_prefix, fn_prefix, memb= ers, base =3D None): >>> + assert field_prefix =3D=3D "" >> >> Makes me wonder why we have a field_prefix parameter. >> >> fn_prefix is also always ""... >=20 > Hmm - looks like I was debugging whether the code was dead (by whether = I > could trigger the assertion) and forgot to clean it up. I'll split tha= t > into a separate patch (I've already done another related cleanup that I= > found while reviewing this code, in commit 6540e9f). In fact, the code was NOT dead until I killed inline structs ("qapi: Drop support for inline nested types"). Which means my cleanup wasn't complete - but as that series is already at v7, I'll do the additional cleanup as its own patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fb9cKSMwBosrmeweoEecB6ohL6PNlqnJ1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVQqz/AAoJEKeha0olJ0NqaOMH/RkHqfhSqQri95aVKZ13/Cdf KezhljNoNdAju6Gyaw3NsY7GtGDpjqdU7bk+Xm5iel2CVvTLB6aZ/fEUhD+qsgyN QHlW5NKBhD14KsY3tkgELuPyDnDgKxdgaPah/u3sRzib18aeE96MFdrqT/0f6ap5 ewPze57Vy+LpnQlU6wrMNLGxf6VBcgGKqv5HrhV1KxbYB+wXMlVq44A1BqKrynLy Z1Ct0DGNlleKnohlcMR9c/iAj6gM+VkHniIRHlmuv53GE3cazYjFn/AVYA7aw6tq 3zjMyI9X6IR6ClDB1HHUkiY0EhNKUDkjCMtpMxPk5y++EUEhVCIOPuANXy6AW/s= =s2mB -----END PGP SIGNATURE----- --fb9cKSMwBosrmeweoEecB6ohL6PNlqnJ1--