qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, berrange@redhat.com,
	peter maydell <peter.maydell@linaro.org>,
	mjt@tls.msk.ru
Subject: Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding
Date: Sat, 15 Oct 2016 17:07:23 -0400 (EDT)	[thread overview]
Message-ID: <554335893.3770945.1476565643777.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161015195308.20473-5-samuel.thibault@ens-lyon.org>


> +#ifdef CONFIG_ICONV
> +    if (font_charset) {
> +        unsigned char ch;
> +        wchar_t wch;
> +        char *pch, *pwch;
> +        size_t sch, swch;
> +        iconv_t conv;
> +
> +        conv = iconv_open("WCHAR_T", font_charset);

Is this portable?  It seems safer to convert to UTF-8 and parse the
resulting character (assuming that wchar_t is Unicode).  There is
already mod_utf8_codepoint for this task.

Paolo

  reply	other threads:[~2016-10-15 21:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 19:53 [Qemu-devel] [PATCH 0/5] curses: wide character support Samuel Thibault
2016-10-15 19:53 ` [Qemu-devel] [PATCH 1/5] curses: fix left/right arrow translation Samuel Thibault
2016-10-15 19:53 ` [Qemu-devel] [PATCH 2/5] curses: Use cursesw instead of curses Samuel Thibault
2016-10-15 19:53 ` [Qemu-devel] [PATCH 3/5] curses: use wide output functions Samuel Thibault
2016-10-15 19:53 ` [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding Samuel Thibault
2016-10-15 21:07   ` Paolo Bonzini [this message]
2016-10-25 23:16   ` Samuel Thibault
2016-10-15 19:53 ` [Qemu-devel] [PATCH 5/5] curses: support wide input Samuel Thibault
2016-10-25 22:26 ` [Qemu-devel] [PATCH 0/5] curses: wide character support Samuel Thibault
2016-10-26 10:05   ` Gerd Hoffmann
2016-10-26 11:43     ` Samuel Thibault
2016-10-26 12:18       ` Gerd Hoffmann
2016-10-26 12:40       ` Gerd Hoffmann
2016-10-26 15:19         ` Samuel Thibault
  -- strict thread matches above, loose matches on Subject: below --
2016-06-22 22:23 Samuel Thibault
2016-06-22 22:23 ` [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding Samuel Thibault
2016-06-23  7:34   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554335893.3770945.1476565643777.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).