From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yo9xD-0005sz-OP for qemu-devel@nongnu.org; Fri, 01 May 2015 08:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yo9xA-0001Kg-J6 for qemu-devel@nongnu.org; Fri, 01 May 2015 08:22:03 -0400 Message-ID: <55436FE6.8070305@redhat.com> Date: Fri, 01 May 2015 06:21:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430477086-26830-1-git-send-email-berrange@redhat.com> In-Reply-To: <1430477086-26830-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TF8HRDQacL8bbgi6QLsLbX20S7tE1PRq0" Subject: Re: [Qemu-devel] [PATCH] ui: remove check for failure of qemu_acl_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Gerd Hoffmann This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TF8HRDQacL8bbgi6QLsLbX20S7tE1PRq0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/01/2015 04:44 AM, Daniel P. Berrange wrote: > The qemu_acl_init() function has long since stopped being able > to return NULL, since g_malloc will abort on OOM. As such the > checks for NULL were unreachable code. >=20 > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 8 -------- > 1 file changed, 8 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --TF8HRDQacL8bbgi6QLsLbX20S7tE1PRq0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVQ2/nAAoJEKeha0olJ0Nq6roH/08S32qQTa7Ytg+Jp8T8edyb 4CTnCDAzm5zTPtJvO9fpqwb2wAyWtia/iboL3NGAuBcP2Pxya74HY6vtqR41ouJW CzqVqIbvqMDB7HGg80XH9723tztfBmxj41X3ux6DWy/r4mYgw8zztMoJf7sWe/T9 stvlsN2+WsRmivKxVfrMn28KYU2vC8o5jJgm+or11niOxCZdKnBbgICwxvx5MAdf DfMhMmZgw0TOjSEZCjOBidO7H5SqRmuPLYl+TaKnRhtzqcy439y5RBdwXoutwl2C 3tY6F/gIEPnuCtxaPd/RTM5eRv0r97ien2Kww1mZTlerijy5cEPCqocYrpP1we4= =MlGB -----END PGP SIGNATURE----- --TF8HRDQacL8bbgi6QLsLbX20S7tE1PRq0--