From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YoFTU-0000Td-Kc for qemu-devel@nongnu.org; Fri, 01 May 2015 14:15:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YoFTQ-0004iW-4r for qemu-devel@nongnu.org; Fri, 01 May 2015 14:15:44 -0400 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:35917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YoFTP-0004iG-O4 for qemu-devel@nongnu.org; Fri, 01 May 2015 14:15:40 -0400 Received: by wgen6 with SMTP id n6so97271108wge.3 for ; Fri, 01 May 2015 11:15:38 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5543C2BC.8020208@redhat.com> Date: Fri, 01 May 2015 20:15:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430489347-13772-1-git-send-email-ehabkost@redhat.com> <1430489347-13772-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1430489347-13772-2-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] qom: Implement object_property_add_const_link() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mimu@linux.vnet.ibm.com, agraf@suse.de, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, Igor Mammedov , =?windows-1252?Q?Andreas_F=E4rber?= , david@gibson.dropbear.id.au On 01/05/2015 16:09, Eduardo Habkost wrote: > +void object_property_add_const_link(Object *obj, const char *name, > + const char *type, Object *child, > + ObjectPropertyLinkFlags flags, > + Error **errp) > +{ > + Object **childp = g_new0(Object*, 1); > + > + *childp = child; > + object_property_add_link(obj, name, type, childp, NULL, > + flags | OBJ_PROP_LINK_FREE_CHILD_POINTER, errp); > +} > + This works, but is the extra functionality needed, compared to an alias? Namely, when is flags going to be != 0? FWIW, here is my ./.. patch. I'm all for adding a helper like object_property_add_const_link on top if we go for it. Another possibility is to not introduce any of our patches and reuse the child<> getter and resolve functions in object_property_add_const_link. -------------------- 8< --------------- >>From 653ca80e93fcaa94c7fa172edbaef75457d4952d Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Tue, 31 Mar 2015 13:56:24 +0200 Subject: [PATCH] qom: add . and .. properties Signed-off-by: Paolo Bonzini --- qom/object.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/qom/object.c b/qom/object.c index b8dff43..3dd87b7 100644 --- a/qom/object.c +++ b/qom/object.c @@ -1783,9 +1783,51 @@ void object_property_set_description(Object *obj, const char *name, op->description = g_strdup(description); } +static void property_get_dot(Object *obj, struct Visitor *v, void *opaque, + const char *name, Error **errp) +{ + gchar *path = object_get_canonical_path(obj); + visit_type_str(v, &path, name, errp); + g_free(path); +} + +static Object *property_resolve_dot(Object *obj, void *opaque, + const gchar *part) +{ + return obj; +} + +static void property_get_dotdot(Object *obj, struct Visitor *v, void *opaque, + const char *name, Error **errp) +{ + if (obj->parent) { + gchar *path = object_get_canonical_path(obj); + visit_type_str(v, &path, name, errp); + g_free(path); + } else { + gchar *path = (gchar *)""; + visit_type_str(v, &path, name, errp); + } +} + +static Object *property_resolve_dotdot(Object *obj, void *opaque, + const gchar *part) +{ + return obj->parent; +} + static void object_instance_init(Object *obj) { + ObjectProperty *op; object_property_add_str(obj, "type", qdev_get_type, NULL, NULL); + + op = object_property_add(obj, ".", "link", property_get_dot, + NULL, NULL, NULL, NULL); + op->resolve = property_resolve_dot; + + op = object_property_add(obj, "..", "link", property_get_dotdot, + NULL, NULL, NULL, NULL); + op->resolve = property_resolve_dotdot; } static void register_types(void) -- 2.3.5