From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpDAa-0000Gs-JY for qemu-devel@nongnu.org; Mon, 04 May 2015 06:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpDAV-0000uf-M8 for qemu-devel@nongnu.org; Mon, 04 May 2015 06:00:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpDAV-0000tj-FS for qemu-devel@nongnu.org; Mon, 04 May 2015 06:00:07 -0400 Message-ID: <55474318.8090501@redhat.com> Date: Mon, 04 May 2015 11:59:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430421547-18278-1-git-send-email-ehabkost@redhat.com> <20150504114728.0dd227dd@nial.brq.redhat.com> In-Reply-To: <20150504114728.0dd227dd@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] cpu: Register QOM links at /machine/cpus/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Eduardo Habkost Cc: peter.maydell@linaro.org, mimu@linux.vnet.ibm.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, =?windows-1252?Q?Andre?= =?windows-1252?Q?as_F=E4rber?= , david@gibson.dropbear.id.au On 04/05/2015 11:47, Igor Mammedov wrote: > On Thu, 30 Apr 2015 16:19:07 -0300 > Eduardo Habkost wrote: > > > This will provide a predictable path for the CPU objects, and a more > > powerful alternative for the query-cpus QMP command, as now every QOM > > property on CPU objects can be easily queried. > > provided the way cpu_index is generated, path won't be predictable/stable > with CPU unplug. I'd rather use DEVICE->id instead of cpu_index. Can we use the APIC id then? Perhaps wrapped with a CPUState-level method get_stable_processor_id()? Paolo