qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: safford@watson.ibm.com, Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, quan.xu@intel.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM
Date: Mon, 04 May 2015 14:39:32 -0400	[thread overview]
Message-ID: <5547BCE4.2070200@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150504161610.GA21157@morn.localdomain>

On 05/04/2015 12:16 PM, Kevin O'Connor wrote:
> On Mon, May 04, 2015 at 11:22:25AM -0400, Stefan Berger wrote:
>> On 05/04/2015 05:16 AM, Igor Mammedov wrote:
>>> On Wed, 29 Apr 2015 12:42:21 -0400
>>>> 2 choices now -- which one to take?
>>> I'd try installing extra SSDT table first as a cleanest way (seabios only)
>>> and if it fails fallback to TIS path.
>> I did some experiment where I tried to use AML's Store() call to see whether
>> it can read from some entry in another scope, similar to what the specs show
>> on page 487, so that one could read the base address that is written
>> elsewhere. The problem seems to be that there is no actual searching going
>> on for accessing a scope during runtime, but this seems to be done during
>> compile time. So something like Store(\_SB.I2C1.Y, BUFF) from the specs
>> needs to have a SCOPE(\_SB.I2C1...) available during compile time.
> You can reference scopes provided by other SSDTs/DSDT using the
> "External()" acpi command.

Tried it. Works with the \DBUG function for example.

As an example, External(\BASE) would give allow us to get the base address.
The AML code for BASE, something like this

     Scope(\) {
         Name(BASE, 0x12345678)
     }


Access to it would be like this:

Store(\BASE, Local0)

The above first snippet would have to be compiled by SeaBIOS. 0x12345678 
would in this case be the address allocated by SeaBIOS where the AML 
code for PPI could read/write the PPID data to/from. Kevin and I had an 
offline conversation about this and Kevin doesn't seem to like the idea 
of a split implementation of ACPI table generation. I would then extend 
the TIS with a couple of bytes that retain the data across a reset.

    Stefan

  reply	other threads:[~2015-05-04 18:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 22:38 [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM Stefan Berger
2015-04-15 22:38 ` [Qemu-devel] [PATCH 1/5] Provide support for the CUSE TPM Stefan Berger
2015-04-15 22:38 ` [Qemu-devel] [PATCH 2/5] Support Physical Presence Interface Spec Stefan Berger
2015-04-15 22:38 ` [Qemu-devel] [PATCH 3/5] Introduce condition to notifiy waiters of completed command Stefan Berger
2015-04-15 22:38 ` [Qemu-devel] [PATCH 4/5] Introduce condition in TPM backend for notification Stefan Berger
2015-04-15 22:38 ` [Qemu-devel] [PATCH 5/5] Add support for VM suspend/resume for TPM TIS Stefan Berger
2015-04-16 13:35 ` [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM Igor Mammedov
2015-04-16 14:05   ` Stefan Berger
2015-04-22  7:00     ` Igor Mammedov
2015-04-22 18:18       ` Stefan Berger
2015-04-29  9:06         ` Igor Mammedov
2015-04-29 16:42           ` Stefan Berger
2015-05-04  9:16             ` Igor Mammedov
2015-05-04 15:22               ` Stefan Berger
2015-05-04 16:16                 ` Kevin O'Connor
2015-05-04 18:39                   ` Stefan Berger [this message]
2015-05-04 21:41                     ` Igor Mammedov
2015-05-05  2:50                       ` Kevin O'Connor
2015-05-05 17:42                         ` Stefan Berger
2015-04-16 18:55   ` Michael S. Tsirkin
2015-04-16 19:21     ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5547BCE4.2070200@linux.vnet.ibm.com \
    --to=stefanb@linux.vnet.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quan.xu@intel.com \
    --cc=safford@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).