From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpLHJ-0006BS-C9 for qemu-devel@nongnu.org; Mon, 04 May 2015 14:39:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpLHF-0007rk-Bn for qemu-devel@nongnu.org; Mon, 04 May 2015 14:39:41 -0400 Received: from e34.co.us.ibm.com ([32.97.110.152]:52180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpLHF-0007rf-59 for qemu-devel@nongnu.org; Mon, 04 May 2015 14:39:37 -0400 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 May 2015 12:39:36 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id AE44E3E40030 for ; Mon, 4 May 2015 12:39:33 -0600 (MDT) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t44IdBHH42991800 for ; Mon, 4 May 2015 11:39:11 -0700 Received: from d03av05.boulder.ibm.com (localhost [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t44IdX0T031705 for ; Mon, 4 May 2015 12:39:33 -0600 Message-ID: <5547BCE4.2070200@linux.vnet.ibm.com> Date: Mon, 04 May 2015 14:39:32 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1429137528-1069064-1-git-send-email-stefanb@linux.vnet.ibm.com> <20150416153506.3260becd@nial.brq.redhat.com> <552FC1AF.4030208@linux.vnet.ibm.com> <20150422090001.4191222f@nial.brq.redhat.com> <5537E60F.2050106@linux.vnet.ibm.com> <20150429110644.2000ebb8@nial.brq.redhat.com> <554109ED.7050500@linux.vnet.ibm.com> <20150504111602.079dc13b@nial.brq.redhat.com> <55478EB1.3020500@linux.vnet.ibm.com> <20150504161610.GA21157@morn.localdomain> In-Reply-To: <20150504161610.GA21157@morn.localdomain> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] Extend TPM support with a QEMU-external TPM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: safford@watson.ibm.com, Igor Mammedov , qemu-devel@nongnu.org, quan.xu@intel.com, mst@redhat.com On 05/04/2015 12:16 PM, Kevin O'Connor wrote: > On Mon, May 04, 2015 at 11:22:25AM -0400, Stefan Berger wrote: >> On 05/04/2015 05:16 AM, Igor Mammedov wrote: >>> On Wed, 29 Apr 2015 12:42:21 -0400 >>>> 2 choices now -- which one to take? >>> I'd try installing extra SSDT table first as a cleanest way (seabios only) >>> and if it fails fallback to TIS path. >> I did some experiment where I tried to use AML's Store() call to see whether >> it can read from some entry in another scope, similar to what the specs show >> on page 487, so that one could read the base address that is written >> elsewhere. The problem seems to be that there is no actual searching going >> on for accessing a scope during runtime, but this seems to be done during >> compile time. So something like Store(\_SB.I2C1.Y, BUFF) from the specs >> needs to have a SCOPE(\_SB.I2C1...) available during compile time. > You can reference scopes provided by other SSDTs/DSDT using the > "External()" acpi command. Tried it. Works with the \DBUG function for example. As an example, External(\BASE) would give allow us to get the base address. The AML code for BASE, something like this Scope(\) { Name(BASE, 0x12345678) } Access to it would be like this: Store(\BASE, Local0) The above first snippet would have to be compiled by SeaBIOS. 0x12345678 would in this case be the address allocated by SeaBIOS where the AML code for PPI could read/write the PPID data to/from. Kevin and I had an offline conversation about this and Kevin doesn't seem to like the idea of a split implementation of ACPI table generation. I would then extend the TIS with a couple of bytes that retain the data across a reset. Stefan