From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ypa68-00018U-4s
	for qemu-devel@nongnu.org; Tue, 05 May 2015 06:29:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Ypa67-0004vY-92
	for qemu-devel@nongnu.org; Tue, 05 May 2015 06:29:08 -0400
Message-ID: <55489B67.1070007@redhat.com>
Date: Tue, 05 May 2015 12:28:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150430222138.GA9389@flamenco>
In-Reply-To: <20150430222138.GA9389@flamenco>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests: consolidate common includes under
	libqtest.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Stefan Weil <sw@weilnetz.de>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Michael Tokarev <mjt@tls.msk.ru>, QEMU Developers <qemu-devel@nongnu.org>

On 01/05/2015 00:21, Emilio G. Cota wrote:
> Something like the appended?
> 
> Cheers,
> 
> 		Emilio

Pretty good, but I wouldn't use qemu-common.h, at least not until all
the function and macro declarations are moved to separate headers (some
of them may indeed move to osdep.h, in fact).

Paolo

> commit eb415d0695bb49d9df78aedaf4ed3c7083a1a574
> Author: Emilio G. Cota <cota@braap.org>
> Date:   Thu Apr 30 18:00:01 2015 -0400
> 
>     tests: consolidate common includes under libqtest.h
>     
>     Source files in tests/ include very common headers,
>     such as glib.h or qemu/osdep.h.
>     
>     Consolidate these includes by including qemu-common.h from
>     libqtest.h, which is a common include in tests/.
>     
>     Two things worth mentioning:
>     
>     - i440fx-test drops its ARRAY_SIZE definition, which comes now
>       from osdep.h via qemu-common.h.
>     
>     - vhost-user-test.c does keep its include of glib.h, since
>       it has to do some contortions to support old glib versions.
>       See commit "bd95939f qtest: fix qtest for vhost-user".
>     
>     Signed-off-by: Emilio G. Cota <cota@braap.org>