From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpfZs-0007CU-AG for qemu-devel@nongnu.org; Tue, 05 May 2015 12:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpfZj-0004UX-NC for qemu-devel@nongnu.org; Tue, 05 May 2015 12:20:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpfZj-0004Te-GK for qemu-devel@nongnu.org; Tue, 05 May 2015 12:20:03 -0400 Message-ID: <5548EDAD.1030608@redhat.com> Date: Tue, 05 May 2015 18:19:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430510112-30474-1-git-send-email-jsnow@redhat.com> <1430510112-30474-5-git-send-email-jsnow@redhat.com> <5543E688.6020703@redhat.com> <554416B2.50904@redhat.com> <55489D00.7050303@redhat.com> <5548E664.4030903@redhat.com> In-Reply-To: <5548E664.4030903@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] libqos/ahci: Swap memread/write with bufread/write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: marc.mari.barcelo@gmail.com, afaerber@suse.de, stefanha@redhat.com On 05/05/2015 17:48, John Snow wrote: > I specifically left things that alter control flow using hex nibbles -- > such as the FIS packets, PRD tables, and all other existing tests. I > only use the b64 encoding for raw data patterns, which don't really need > to be debugged. Either they match or they don't: any particular values > are uninteresting. To some extent: they may still be interesting for stuff like IDENTIFY. > Any future test can be switched to/from hex/b64 by just altering > "mem{read,write}()" to "buf{read,write}()" as desired. I specifically > opted not to alter *all* qtest IO for this very reason. > > Does that help? :) Yes. We could also switch unconditionally to b64, but keep hex in the qtest-log. > If you're not opposed to the rest of this series, I will send a v2 > including the hex batching optimization. This series is okay. I just wanted some clarifications and ideas for future work. Paolo