From: Richard Henderson <rth@twiddle.net>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, claudio.fontana@gmail.com,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
agraf@suse.de, edgari@xilinx.com, edgar.iglesias@gmail.com
Subject: Re: [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable
Date: Tue, 05 May 2015 10:22:45 -0700 [thread overview]
Message-ID: <5548FC65.6050005@twiddle.net> (raw)
In-Reply-To: <d99c7edf85168916b973679f34e75920d2a6b8d6.1430798763.git.crosthwaite.peter@gmail.com>
On 05/04/2015 09:45 PM, Peter Crosthwaite wrote:
> - explicit QEMUDisassembler(FILE *stream) : stream_(stream) { }
> + explicit QEMUDisassembler() { }
The explicit is no longer helpful, and I'd still initialize stream_ to null.
r~
next prev parent reply other threads:[~2015-05-05 17:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 4:44 [Qemu-devel] [PATCH 0/7] disas: Unify target_disas and monitor_disas Peter Crosthwaite
2015-05-05 4:44 ` [Qemu-devel] [PATCH 1/7] disas: Create factored out fn for monitor and target disas Peter Crosthwaite
2015-05-05 14:45 ` Claudio Fontana
2015-05-05 4:44 ` [Qemu-devel] [PATCH 2/7] disas: microblaze: Migrate setup to common code Peter Crosthwaite
2015-05-05 4:45 ` [Qemu-devel] [PATCH 3/7] disas: cris: Fix 0 buffer length case Peter Crosthwaite
2015-05-05 4:45 ` [Qemu-devel] [PATCH 4/7] disas: cris: Migrate setup to common code Peter Crosthwaite
2015-05-05 4:45 ` [Qemu-devel] [PATCH 5/7] disas: arm-a64: Make printfer and stream variable Peter Crosthwaite
2015-05-05 14:41 ` Claudio Fontana
2015-05-05 17:22 ` Richard Henderson [this message]
2015-05-05 4:45 ` [Qemu-devel] [PATCH 6/7] monitor: "i": Add ARM specifics Peter Crosthwaite
2015-05-05 14:40 ` Claudio Fontana
2015-05-05 17:19 ` Peter Maydell
2015-05-05 17:43 ` Richard Henderson
2015-05-06 6:57 ` Peter Crosthwaite
2015-05-06 13:57 ` Richard Henderson
2015-05-06 7:06 ` Peter Crosthwaite
2015-05-06 14:12 ` Richard Henderson
2015-05-06 14:17 ` Paolo Bonzini
2015-05-06 14:32 ` Stefano Stabellini
2015-05-06 15:44 ` Peter Maydell
2015-05-06 18:24 ` Richard Henderson
2015-05-06 18:39 ` Peter Maydell
2015-05-05 4:45 ` [Qemu-devel] [PATCH 7/7] disas: arm: Use target_disas impl for monitor Peter Crosthwaite
2015-05-05 14:38 ` Claudio Fontana
2015-05-05 16:48 ` Peter Crosthwaite
2015-05-05 17:18 ` [Qemu-devel] [PATCH 0/7] disas: Unify target_disas and monitor_disas Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548FC65.6050005@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=claudio.fontana@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgari@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).