From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com, jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: Re: [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty
Date: Tue, 05 May 2015 15:57:12 -0600 [thread overview]
Message-ID: <55493CB8.8020507@redhat.com> (raw)
In-Reply-To: <1430830009-29839-3-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On 05/05/2015 06:46 AM, Fam Zheng wrote:
> Using this function woule always be wrong because a dirty bitmap must
s/woule/would/
> have a specific owner that consumes the dirty bits and calls
> bdrv_reset_dirty_bitmap().
>
> Remove the unused function to avoid future misuse.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 12 ------------
> include/block/block_int.h | 2 --
> 2 files changed, 14 deletions(-)
>
Reviewed-by Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-05 21:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 12:46 [Qemu-devel] [PATCH 0/4] block: Mirror discarded sectors Fam Zheng
2015-05-05 12:46 ` [Qemu-devel] [PATCH 1/4] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-05-05 13:06 ` Paolo Bonzini
2015-05-06 1:45 ` Fam Zheng
2015-05-06 8:59 ` Paolo Bonzini
2015-05-06 9:50 ` Fam Zheng
2015-05-06 10:21 ` Paolo Bonzini
2015-05-11 8:02 ` Fam Zheng
2015-05-11 8:33 ` Paolo Bonzini
2015-05-05 12:46 ` [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty Fam Zheng
2015-05-05 21:57 ` Eric Blake [this message]
2015-05-05 12:46 ` [Qemu-devel] [PATCH 3/4] qemu-iotests: Make block job methods common Fam Zheng
2015-05-05 22:17 ` John Snow
2015-05-06 1:48 ` Fam Zheng
2015-05-05 12:46 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: Add test case for mirror with unmap Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55493CB8.8020507@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).