From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpkqB-00037d-1H for qemu-devel@nongnu.org; Tue, 05 May 2015 17:57:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpkqA-00071I-6N for qemu-devel@nongnu.org; Tue, 05 May 2015 17:57:22 -0400 Message-ID: <55493CB8.8020507@redhat.com> Date: Tue, 05 May 2015 15:57:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430830009-29839-1-git-send-email-famz@redhat.com> <1430830009-29839-3-git-send-email-famz@redhat.com> In-Reply-To: <1430830009-29839-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t95DHG7EbaH4c2wHFLv5Ba33VDeGAuR5X" Subject: Re: [Qemu-devel] [PATCH 2/4] block: Remove bdrv_reset_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi , pbonzini@redhat.com, jsnow@redhat.com, wangxiaolong@ucloud.cn This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t95DHG7EbaH4c2wHFLv5Ba33VDeGAuR5X Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/05/2015 06:46 AM, Fam Zheng wrote: > Using this function woule always be wrong because a dirty bitmap must s/woule/would/ > have a specific owner that consumes the dirty bits and calls > bdrv_reset_dirty_bitmap(). >=20 > Remove the unused function to avoid future misuse. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 12 ------------ > include/block/block_int.h | 2 -- > 2 files changed, 14 deletions(-) >=20 Reviewed-by Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --t95DHG7EbaH4c2wHFLv5Ba33VDeGAuR5X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVSTy4AAoJEKeha0olJ0NqZ7wIAJu03v1mDnMsvwe5O8udNWmN HE8pk1zMwgN1KVwyCeeS/3YcJfb9lUeXTc5uG7W3G6D+3rLLVtF8uT6UUgLSb9Pz vrzyTjNDzHSoqDyGVsDwgRBQ7cVPmjQBFDS8PXUIgQiE5O4i2+EoWm3TabXG2693 5afb8hcbQgPWGaHMwhXEuMEkkU4hIAbj4mlwHNnMne/4T7AyYpKDdeQS1b09gKBD HCioxxFiLNt2wj9vQjSjpJLmNkpoSZzhQthmk6Ftq7Fj19sbilmygmK0t3GqiJRs Fyo1Pm/0wB33TVZdpY87bxzeFkJCJugluUUxq45zWWY9mI7AIob3lErlXNqecNc= =RbT7 -----END PGP SIGNATURE----- --t95DHG7EbaH4c2wHFLv5Ba33VDeGAuR5X--