From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpmNT-00078D-JN for qemu-devel@nongnu.org; Tue, 05 May 2015 19:35:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YpmNO-0005NR-EI for qemu-devel@nongnu.org; Tue, 05 May 2015 19:35:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YpmNO-0005NK-8l for qemu-devel@nongnu.org; Tue, 05 May 2015 19:35:46 -0400 Message-ID: <554953D0.6090701@redhat.com> Date: Tue, 05 May 2015 19:35:44 -0400 From: John Snow MIME-Version: 1.0 References: <1430864578-22072-1-git-send-email-jsnow@redhat.com> <1430864578-22072-2-git-send-email-jsnow@redhat.com> <554950A9.7050205@redhat.com> In-Reply-To: <554950A9.7050205@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/5] qtest: allow arbitrarily long sends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, afaerber@suse.de On 05/05/2015 07:22 PM, Eric Blake wrote: > On 05/05/2015 04:22 PM, John Snow wrote: >> qtest currently has a static buffer of size 1024 that if we >> overflow, ignores the additional data silently which leads to >> hangs or stream failures. >> >> Use glib's string facilities to allow arbitrarily long data, but >> split this off into a new function, qtest_sendf. >> >> Static data can still be sent using qtest_send, which avoids the >> malloc/copy overflow. > > Did you mean 'overhead' instead of 'overflow'? > Sigh, yes. The fingers run on autopilot without input from the brain. Will nab it if I spin again. >> >> Signed-off-by: John Snow --- qtest.c | 46 >> ++++++++++++++++++++++++++++------------------ 1 file changed, 28 >> insertions(+), 18 deletions(-) >> > >> qtest_send_prefix(chr); - qtest_send(chr, "FAIL Unknown >> command `%s'\n", words[0]); + qtest_sendf(chr, "FAIL >> Unknown command `%s'\n", words[0]); } > > Unrelated - these days, I don't see `this' quoting much any more > (except in m4); most people have moved to 'this' quoting. We could > clean it while touching this line, but it really doesn't affect > correctness either way. > If I spin again I'll get it. > Reviewed-by: Eric Blake >