From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36191)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YpxvZ-0005mO-0F
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:55:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YpxvU-00066D-LN
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:55:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54937)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YpxvT-00065z-J7
	for qemu-devel@nongnu.org; Wed, 06 May 2015 07:55:44 -0400
Message-ID: <554A013A.6060605@redhat.com>
Date: Wed, 06 May 2015 13:55:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1430031884-5483-1-git-send-email-yhindin@redhat.com>
	<1430031884-5483-5-git-send-email-yhindin@redhat.com>
	<554735C6.7040505@redhat.com>
	<244658581.13751547.1430913235034.JavaMail.zimbra@redhat.com>
In-Reply-To: <244658581.13751547.1430913235034.JavaMail.zimbra@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] qemu-ga: Building Windows MSI
	installation with configure/Makefile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yossi Hindin <yhindin@redhat.com>
Cc: yvugenfi@redhat.com, dfleytma@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com



On 06/05/2015 13:53, Yossi Hindin wrote:
>>> > > +${QEMU_GA_MSI}: config-host.mak
>>> > > +
>>> > > +${QEMU_GA_MSI}:  qga/installer/qemu-ga.wxs
>>> > > +	$(call quiet-command,QEMU_GA_VERSION="$(QEMU_GA_VERSION)"
>>> > > QEMU_GA_MANUFACTURER="$(QEMU_GA_MANUFACTURER)"
>>> > > QEMU_GA_DISTRO="$(QEMU_GA_DISTRO)" \
>>> > > +	wixl -o $@ ${QEMU_GA_MSI_ARCH} ${QEMU_GA_MSI_WITH_VSS}
>>> > > ${QEMU_GA_MSI_MINGW_DLL_PATH} $<, "  WIXL  $@")
>> > 
>> > Please use $(...) instead of ${...} for consistency.
>   Fixed. BTW. there are other places  in the 'configure' script where ${} is used.

Do you mean in the Makefile (or the generated .mak files)?

The configure script is a bash script, so it uses ${...} to access
variables.  The Makefile can use either ${...} or $(...), but the
parentheses are preferred over the braces.

Thanks,

Paolo