From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster
Date: Wed, 06 May 2015 15:31:35 +0200 [thread overview]
Message-ID: <554A17B7.5010304@redhat.com> (raw)
In-Reply-To: <1430911774-19006-1-git-send-email-kwolf@redhat.com>
On 06.05.2015 13:29, Kevin Wolf wrote:
> Before a freed cluster can be reused, pending discards for this cluster
> must be processed.
>
> The original assumption was that this was not a problem because discards
> are only cached during discard/write zeroes operations, which are
> synchronous so that no concurrent write requests can cause cluster
> allocations.
>
> However, the discard/write zeroes operation itself can allocate a new L2
> table (and it has to in order to put zero flags there), so make sure we
> can cope with the situation.
>
> This fixes https://bugs.launchpad.net/bugs/1349972.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2-refcount.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2015-05-06 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 11:29 [Qemu-devel] [PATCH] qcow2: Flush pending discards before allocating cluster Kevin Wolf
2015-05-06 13:31 ` Max Reitz [this message]
2015-05-08 10:55 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554A17B7.5010304@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).