From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq05g-0003gb-EQ for qemu-devel@nongnu.org; Wed, 06 May 2015 10:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq05b-0006IE-Ei for qemu-devel@nongnu.org; Wed, 06 May 2015 10:14:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq05b-0006I5-9V for qemu-devel@nongnu.org; Wed, 06 May 2015 10:14:19 -0400 Message-ID: <554A21B6.4070302@redhat.com> Date: Wed, 06 May 2015 16:14:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430913460-13174-1-git-send-email-yhindin@redhat.com> In-Reply-To: <1430913460-13174-1-git-send-email-yhindin@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Patch V2 0/4] [Patch V2 0/4] Windows MSI installation package List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yossi Hindin , qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com On 06/05/2015 13:57, Yossi Hindin wrote: > The second version of commits's set take into account Paolo Bonzini remarks. > > Typo in WXS file fixed, QEMU GA-related CLI options renamed, '--enable-guest-agent-msi'/ > '--disable-guest-agent-msi' processing logic changed so that MSI build is configured > by default, unless some prerequisite is missing and MinGW DLL path variable is computed > together with all QEMU GA MSI variables. > > Also, I've slightly changed Makefile structure so that if MSI build was not configured, > Makefile prints suitable message. > > > Yossi Hindin (4): > qemu-ga: adding vss-[un]install options > qemu-ga: debug printouts to help troubleshoot installation > qemu-ga: Introduce Windows MSI script > qemu-ga: Building Windows MSI installation with configure/Makefile > > Makefile | 24 +++++++- > configure | 66 +++++++++++++++++++++ > qga/channel-win32.c | 2 +- > qga/commands-win32.c | 1 + > qga/installer/qemu-ga.wxs | 145 ++++++++++++++++++++++++++++++++++++++++++++++ > qga/main.c | 10 +++- > 6 files changed, 245 insertions(+), 3 deletions(-) > create mode 100644 qga/installer/qemu-ga.wxs > Reviewed-by: Paolo Bonzini