From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq09l-0001sX-2A for qemu-devel@nongnu.org; Wed, 06 May 2015 10:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq09k-0007mA-79 for qemu-devel@nongnu.org; Wed, 06 May 2015 10:18:36 -0400 Message-ID: <554A22AE.6070203@redhat.com> Date: Wed, 06 May 2015 16:18:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1430911419-8256-1-git-send-email-famz@redhat.com> <1430911419-8256-7-git-send-email-famz@redhat.com> <554A040B.7030108@redhat.com> <20150506122023.GD9991@ad.nay.redhat.com> In-Reply-To: <20150506122023.GD9991@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 6/7] virtio-blk: Don't handle output when there is "device IO" op blocker List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, armbru@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, Stefan Hajnoczi On 06/05/2015 14:20, Fam Zheng wrote: >> > >> > Does non-dataplane need to do anything, since it uses iohandlers rather >> > than aio_set_event_notifier_handler? > I guess it's not for this specific bug. See this as an attempt on a general > purpose "pause" mechanism to the device in investment for the future, for > example, bdrv_aio_drain. ;-) > > I can drop it in v2 if you think the idea is not very helpful. It's slightly more complicated but I think it's worth the extra coverage testing that this provides. Paolo