From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq0UH-0004MV-EU for qemu-devel@nongnu.org; Wed, 06 May 2015 10:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq0UD-0006nt-5x for qemu-devel@nongnu.org; Wed, 06 May 2015 10:39:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq0UC-0006np-WE for qemu-devel@nongnu.org; Wed, 06 May 2015 10:39:45 -0400 Message-ID: <554A27A8.4040700@redhat.com> Date: Wed, 06 May 2015 16:39:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20150506140238.17288.87548.stgit@PASHA-ISP> <20150506140406.17288.85396.stgit@PASHA-ISP> In-Reply-To: <20150506140406.17288.85396.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v13 15/21] bottom halves: introduce bh call function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, fred.konrad@greensocs.com On 06/05/2015 16:04, Pavel Dovgalyuk wrote: > This patch introduces aio_bh_call function. It is used to execute > bottom halves as callbacks without adding them to the queue. > > Signed-off-by: Pavel Dovgalyuk > --- > async.c | 8 +++++++- > include/block/aio.h | 5 +++++ > 2 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/async.c b/async.c > index 46d9e63..734c76c 100644 > --- a/async.c > +++ b/async.c > @@ -59,6 +59,12 @@ QEMUBH *aio_bh_new(AioContext *ctx, QEMUBHFunc *cb, void *opaque) > return bh; > } > > +void aio_bh_call(void *opaque) > +{ > + QEMUBH *bh = (QEMUBH *)opaque; This can have a QEMUBH * argument. I can fix it when committing. > + bh->cb(bh->opaque); > +} > + > /* Multiple occurrences of aio_bh_poll cannot be called concurrently */ > int aio_bh_poll(AioContext *ctx) > { > @@ -82,7 +88,7 @@ int aio_bh_poll(AioContext *ctx) > if (!bh->idle) > ret = 1; > bh->idle = 0; > - bh->cb(bh->opaque); > + aio_bh_call(bh); > } > } > > diff --git a/include/block/aio.h b/include/block/aio.h > index d2bb423..b498704 100644 > --- a/include/block/aio.h > +++ b/include/block/aio.h > @@ -157,6 +157,11 @@ QEMUBH *aio_bh_new(AioContext *ctx, QEMUBHFunc *cb, void *opaque); > void aio_notify(AioContext *ctx); > > /** > + * aio_bh_call: Executes callback function of the specified BH. > + */ > +void aio_bh_call(void *opaque); > + > +/** > * aio_bh_poll: Poll bottom halves for an AioContext. > * > * These are internal functions used by the QEMU main loop. > Works for me! I am not sure why patch 16 works though. :) I'll ponder on it, in the meanwhile some extra explanation from you would be welcome... Paolo