From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Yq2ku-0006H3-UU
	for qemu-devel@nongnu.org; Wed, 06 May 2015 13:05:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Yq2kt-0004FX-Tc
	for qemu-devel@nongnu.org; Wed, 06 May 2015 13:05:08 -0400
Message-ID: <554A49BD.3070006@redhat.com>
Date: Wed, 06 May 2015 11:05:01 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <20150506162011.55A5049ED81@webmail.sinamail.sina.com.cn>
	<554A4967.2050306@redhat.com>
In-Reply-To: <554A4967.2050306@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="1v7qVl8ieSOE4IkThp3OfPrMTPh0S918i"
Subject: Re: [Qemu-devel] [PATCH] keyboard:fix ps2 keyboard can't use
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: penghao122@sina.com, qemu-devel <qemu-devel@nongnu.org>
Cc: qemu-stable <qemu-stable@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1v7qVl8ieSOE4IkThp3OfPrMTPh0S918i
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/06/2015 11:03 AM, Eric Blake wrote:
> On 05/06/2015 10:20 AM, penghao122@sina.com wrote:
>=20
> Missing a 'v2' in the subject line (hint: git send-email -v2)
>=20

>> +++ b/hw/input/pckbd.c
>> @@ -207,6 +207,8 @@ static uint64_t kbd_read_status(void *opaque, hwad=
dr addr,
>> KBDState *s =3D opaque;
>> int val;
>> val =3D s->status;
>> + if(s->write-cmd =3D=3D KBD_CCMD_KBD_ENABLE)
>=20
> Your patch is fatally flawed:

Oh, and also your patch fails scripts/checkpatch.pl due to missing {}
around the 'if' body.  Also something we mention on:

> PLEASE read http://wiki.qemu.org/Contribute/SubmitAPatch

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--1v7qVl8ieSOE4IkThp3OfPrMTPh0S918i
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVSkm9AAoJEKeha0olJ0NqZQkH/Rqv9WPDJRArZYaJGXrKE/cl
9s5pUublxUf8vJ/x+BlZ8daGEJWDG0l6G9wUseGJnw88XGZoNOc/S+ckmloGI2J8
fHV3PADNEPgBpjSfppfWc//TRn439ACEuTseVBtYsQ7mIgPgJxc3EvhVm5jqEXmC
kSC1uOJcACXHbnIkNX8kDCI2ZzCbnnDzSHrfL6NJpwKYPi9yf0L9MhC6/+27yWyN
EY3154cy/+iYmOhj2J6tN3jiaz5cpOpFdq4MksZQZsU4dSoSPUMDuHlTDXUkstTE
PBhookPHcnPr7/Jse+QF5BmVQ0VsDdgxONcMDyfSlOfucpBpaH+qSZRTTqM2fsE=
=bLw/
-----END PGP SIGNATURE-----

--1v7qVl8ieSOE4IkThp3OfPrMTPh0S918i--