From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq4hM-00070w-OY for qemu-devel@nongnu.org; Wed, 06 May 2015 15:09:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yq4hI-0005Ur-7I for qemu-devel@nongnu.org; Wed, 06 May 2015 15:09:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yq4hH-0005Ul-Vl for qemu-devel@nongnu.org; Wed, 06 May 2015 15:09:32 -0400 Message-ID: <554A66E9.80909@redhat.com> Date: Wed, 06 May 2015 13:09:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430934604-18207-1-git-send-email-quintela@redhat.com> <1430934604-18207-13-git-send-email-quintela@redhat.com> In-Reply-To: <1430934604-18207-13-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="reCCDhQEaj9XXcWhuTE6sqQA5bWfbt1R0" Subject: Re: [Qemu-devel] [PULL 12/15] migration: Use an array instead of 3 parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: Yang Zhang , Liang Li This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --reCCDhQEaj9XXcWhuTE6sqQA5bWfbt1R0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2015 11:50 AM, Juan Quintela wrote: > From: Liang Li >=20 > Put the three parameters related to multiple thread (de)compression > into an int array, and use an enum type to index the parameter. >=20 > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 4 +--- > migration/migration.c | 31 +++++++++++++++++++------------ > qapi-schema.json | 23 +++++++++++++++++++++++ > 3 files changed, 43 insertions(+), 15 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -569,6 +569,29 @@ > ## > { 'command': 'query-migrate-capabilities', 'returns': ['MigrationCap= abilityStatus']} >=20 > +# @MigrationParameter > +# > +# Migration parameters enumeration > +# > +# @compress-level: Set the compression level to be used in live migrat= ion, > +# the compression level is an integer between 0 and 9, where = 0 means > +# no compression, 1 means the best compression speed, and 9 m= eans best > +# compression ratio which will consume more CPU. > +# > +# @compress-threads: Set compression thread count to be used in live m= igration, > +# the compression thread count is an integer between 1 and 25= 5. > +# > +# @decompress-threads: Set decompression thread count to be used in li= ve > +# migration, the decompression thread count is an integer bet= ween 1 > +# and 255. Usually, decompression is at least 4 times as fast= as > +# compression, so set the decompress-threads to the number ab= out 1/4 > +# of compress-threads is adequate. > +# > +# Since: 2.3 s/2.3/2.4/ (okay as part of the followup patch) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --reCCDhQEaj9XXcWhuTE6sqQA5bWfbt1R0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVSmbpAAoJEKeha0olJ0Nqb/0IAKSC1yzi3ryodEsZjsR04aLe ZivCNm7aoF7kCuChhNzfDv+qNMX4wurwyjhOEqib0A5T1AX1WcWmftpFtrOwusLp wdHlv+YUXFmhq3o5jq7FPyLoh1nGPg0Kra+WE7yOGgPQkXEDkzi5z8SBE2ahw3Gc DhydFxmFDwlWD/mvFhUNmT3GIdL1hMFa86y1VS15osTb9CxCIwDFHQ7WxxYjwcwr AjtYXtjyB1FvivzIaDDT3KJcxdTAix8ZgGe6Eo8zK5UEc5GWzUHbqUWFBfD3kmz7 I7BKeT59/G7m/HLEyeFtkrKz+2uMM3Am+/DoxQwtptgFsdcOyOJ2+8plenX0PSQ= =Zsgi -----END PGP SIGNATURE----- --reCCDhQEaj9XXcWhuTE6sqQA5bWfbt1R0--