From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols
Date: Thu, 07 May 2015 14:20:56 +0200 [thread overview]
Message-ID: <554B58A8.6000203@redhat.com> (raw)
In-Reply-To: <554A4E2D.4050300@redhat.com>
On 06/05/2015 19:23, Max Reitz wrote:
> The guest sees whatever has been written into reply->error, and that
> field hasn't been written by this function in that case. It has been
> written by nbd_receive_reply() in nbd.c, and that value comes directly
> from the server. In case of qemu-nbd being the server, a write beyond
> the EOF should be caught by blk_check_byte_request() in
> block/block-backend.c, which returns -EIO. So that's where the EIO comes
> from.
Fair enough. This makes sense, but then we have to create ENOSPC elsewhere.
> I don't know whether this EIO is subsequently converted to ENOSPC
> because of werror=enospc, but considering that
> https://bugzilla.redhat.com/show_bug.cgi?id=1090713 did not override
> werror, it doesn't look like it.
No, it shouldn't indeed.
Could alloc_clusters_noref do bdrv_truncate and return ENOSPC if it
fails? That's how for example qcow and vhdx work. vdi has the same
problem.
Paolo
next prev parent reply other threads:[~2015-05-07 12:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:03 [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols Max Reitz
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 1/3] iotests: Make nested read in 072 and 089 read-only Max Reitz
2015-03-19 19:23 ` Eric Blake
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 2/3] block: Introduce BDS.growing Max Reitz
2015-03-19 20:11 ` Eric Blake
2015-03-19 19:03 ` [Qemu-devel] [PATCH v2 3/3] block: Introduce BlockDriver.requires_growing_file Max Reitz
2015-03-19 20:18 ` Eric Blake
2015-05-05 9:46 ` [Qemu-devel] [PATCH v2 0/3] block: Warn about usage of growing formats over non-growable protocols Stefan Hajnoczi
2015-05-06 13:04 ` Max Reitz
2015-05-06 15:30 ` Paolo Bonzini
2015-05-06 16:12 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-05-06 16:20 ` Paolo Bonzini
2015-05-06 16:37 ` Max Reitz
2015-05-06 16:47 ` Paolo Bonzini
2015-05-06 17:23 ` Max Reitz
2015-05-07 12:20 ` Paolo Bonzini [this message]
2015-05-07 12:29 ` Kevin Wolf
2015-05-07 12:47 ` Paolo Bonzini
2015-05-07 13:20 ` Kevin Wolf
2015-05-07 13:55 ` Paolo Bonzini
2015-05-07 14:07 ` Kevin Wolf
2015-05-07 14:16 ` Paolo Bonzini
2015-05-07 14:34 ` Kevin Wolf
2015-05-07 14:50 ` Paolo Bonzini
2015-05-08 10:08 ` Kevin Wolf
2015-05-08 10:16 ` Paolo Bonzini
2015-05-08 10:34 ` Kevin Wolf
2015-05-08 11:00 ` Paolo Bonzini
2015-05-08 12:58 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B58A8.6000203@redhat.com \
--to=pbonzini@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).