From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: quintela@redhat.com, qemu-devel@nongnu.org,
Liang Li <liang.z.li@intel.com>,
armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com,
yang.z.zhang@intel.com
Subject: Re: [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression
Date: Thu, 07 May 2015 16:18:11 +0200 [thread overview]
Message-ID: <554B7423.8080509@redhat.com> (raw)
In-Reply-To: <20150507141359.GG2139@work-vm>
On 07/05/2015 16:13, Dr. David Alan Gilbert wrote:
>> > Perhaps you can add a counter to the CompressParam struct, and sum all
>> > counters in norm_mig_pages_transferred/norm_mig_bytes_transferred (the
>> > latter probably should just call norm_mig_pages_transferred)?
> The 'ram_save_compressed_page' that Liang Li has added here is basically
> the same as the ram_save_page we've already got but with the extra
> bits for compression, and this non-atomic inc is in the code simply copied
> to handle the 'ram_control_save_page' case (i.e. RDMA).
>
> So it is safe, because I don't think any pages will get handed to the
> compression threads (and hence hit the atomic inc's) if RDMA is hooking
> the ram_control_save_page.
Right, but still it depends on RDMA handling all pages with no
exception. So it's still pretty ugly, even if it happens to work.
Paolo
next prev parent reply other threads:[~2015-05-07 14:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 9:26 [Qemu-devel] [PATCH v8 0/14] migration: Add a new feature to do live migration Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 01/14] docs: Add a doc about multiple thread compression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 02/14] migration: Add the framework of multi-thread compression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 03/14] migration: Add the framework of multi-thread decompression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 04/14] qemu-file: Add compression functions to QEMUFile Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 05/14] arch_init: Alloc and free data struct for compression Liang Li
2015-05-07 13:00 ` Paolo Bonzini
2015-04-15 9:26 ` [Qemu-devel] [v8 06/14] arch_init: Add and free data struct for decompression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 07/14] migration: Split save_zero_page from ram_save_page Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 08/14] migration: Add the core code of multi-thread compression Liang Li
2015-05-07 13:02 ` Paolo Bonzini
2015-05-07 14:13 ` Dr. David Alan Gilbert
2015-05-07 14:18 ` Paolo Bonzini [this message]
2015-04-15 9:26 ` [Qemu-devel] [v8 09/14] migration: Make compression co-work with xbzrle Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 10/14] migration: Add the core code for decompression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 11/14] migration: Add interface to control compression Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 12/14] migration: Use an array instead of 3 parameters Liang Li
2015-04-15 9:26 ` [Qemu-devel] [v8 13/14] migration: Add qmp commands to set and query parameters Liang Li
2015-05-11 11:58 ` Dr. David Alan Gilbert
2015-05-12 13:05 ` Li, Liang Z
2015-05-12 13:51 ` Dr. David Alan Gilbert
2015-04-15 9:26 ` [Qemu-devel] [v8 14/14] migration: Add hmp interface " Liang Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B7423.8080509@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=liang.z.li@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).