From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqNMj-0006Ob-Rx for qemu-devel@nongnu.org; Thu, 07 May 2015 11:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqNMf-0003GT-Oo for qemu-devel@nongnu.org; Thu, 07 May 2015 11:05:33 -0400 Message-ID: <554B7F2C.1040206@redhat.com> Date: Thu, 07 May 2015 09:05:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> In-Reply-To: <1430971496-32659-1-git-send-email-phoeagon@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gRGKgGiVEq4sUglXWdcK0EmlrfbPoGtEF" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhe Qiu , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gRGKgGiVEq4sUglXWdcK0EmlrfbPoGtEF Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/06/2015 10:04 PM, Zhe Qiu wrote: > From: phoeagon >=20 > In reference to b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b= 0db262c4b05fee51d01de2d1d2, metadata writes to qcow2/cow/qcow/vpc/vmdk ar= e all synced prior to succeeding writes. >=20 Please wrap commit comments to be under 80 columns (in fact, under 72 is good, because 'git log' adds spaces when displaying commit bodies). Your notation of commit~commit is unusual; ranges in git are usually spelled commit..commit. Also, it's okay to abbreviate commit SHAs to 8 bytes or so. So to shrink your long line, I'd write b0ad5a45..078a458e. > Only when write is successful that bdrv_flush is called. >=20 > Signed-off-by: Zhe Qiu Your 'From:' and 'Signed-off-by:' lines have different spellings, which makes it more confusing when searching for patches by you. You can add an entry to .mailmap (as a separate patch) to retro-actively consolidate entries, but it is better to catch things like this up front before we even have the problem of separate names. I suspect you want "Zhe Qiu" as the spelling of your name in both lines (git config can be taught to set up the preferred name to attribute both for signing patches and for sending email). It is also acceptable to use UTF-8 to spell your name in native characters, or even a combination of "native name (ascii counterpart)" --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gRGKgGiVEq4sUglXWdcK0EmlrfbPoGtEF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVS38sAAoJEKeha0olJ0NqMbUH/0io0Q3Dx4o4IHQSmj0wJ/w1 YPJs3VFd8+U6wrsFmIjT2XZb45ILT9RHOd9tU5RJoIH/SCfKWfP0y6Z03bmixD5x BWT7kEjMUZ6g244qT82pS0xNAhfOSgR5BtsW2c6B5uQYu0PizoFmF5c3bR+CeyxO 5DnThDz5KMNCv8lp3T9+zA9d96xhQmBoJo2wJksbhsoDeJr+YbjnHFq4S6WxOaxT BdJQJxK8EiFT1GDaLzh+cAL8QjEGNG/SLnR5OweukioqKDENqFr9oV1Hit2MYiBJ PeE8od/2FbNbg9K6igxNxJamFxUwsHO3f/HPADlNI3D/TK1VT/5KdgcU1UbOGuI= =wKKY -----END PGP SIGNATURE----- --gRGKgGiVEq4sUglXWdcK0EmlrfbPoGtEF--