From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPAz-0006S1-BB for qemu-devel@nongnu.org; Thu, 07 May 2015 13:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqPAw-0001k7-6n for qemu-devel@nongnu.org; Thu, 07 May 2015 13:01:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPAw-0001k3-1p for qemu-devel@nongnu.org; Thu, 07 May 2015 13:01:30 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 70C3CB72CF for ; Thu, 7 May 2015 17:01:28 +0000 (UTC) Message-ID: <554B9A67.60004@redhat.com> Date: Thu, 07 May 2015 11:01:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431012374-14113-1-git-send-email-pbonzini@redhat.com> <1431012374-14113-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1431012374-14113-2-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="24cpqPacrK2xr4P6Mws9vST1qojMGMxNq" Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: only send a limited number of errno codes on the wire List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --24cpqPacrK2xr4P6Mws9vST1qojMGMxNq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/07/2015 09:26 AM, Paolo Bonzini wrote: > Right now, NBD includes potentially platform-specific error values in > the wire protocol. >=20 > Luckily, most common error values are more or less universal: in > particular, of all errno values <=3D 34 (up to ERANGE), they are all > the same on supported platforms except for 11 (which is EAGAIN on > Windows and Linux, but EDEADLK on Darwin and the *BSDs). Well, this is not true on GNU Hurd, but to my knowledge no one has tried to compile qemu on Hurd. > =20 > + /* NBD errors should be universally equal to the corresponding > + * errno values, check it here. > + */ > + QEMU_BUILD_BUG_ON(EPERM !=3D 1); And this is (probably not the first place) where qemu compilation would fail on Hurd. At any rate, I see no reason to hold up the patch on that ground. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --24cpqPacrK2xr4P6Mws9vST1qojMGMxNq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVS5pnAAoJEKeha0olJ0Nqi1QH/RYIkMwAWbJbGApeabT4sqFP 46FqG99DQieSX4xBnp9Bcqtd+zsdxqFMrnfcPMjiJB3gRkehY2WlxB9UWxVEtNqx n0hG7heF/PXQ9vF9SjsFq2rCS1v/tFW3UpIU3EAAlg4mJhmf9IH+1KyiBSbMYmtK wBCnR3pTUmOjnEhFZ1Mkjly2CQYQC4ymS3uJCIiFIWHwxGrS+89j7uHvsbuQL8hR dS0KuqYpPqSb+O8e1DlnUupJot3zmfIpOwJ2BfbFND9ERkzaxrAquk1aO6eDZkqk Q1PNSshQQ1LD9uMDSJrBnkmKGkv/aAeTtBW9/miwj+UyQrQtIsFAooNKLdCzNn8= =WKVP -----END PGP SIGNATURE----- --24cpqPacrK2xr4P6Mws9vST1qojMGMxNq--