From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: only send a limited number of errno codes on the wire
Date: Thu, 07 May 2015 19:06:46 +0200 [thread overview]
Message-ID: <554B9BA6.4050805@redhat.com> (raw)
In-Reply-To: <554B9A67.60004@redhat.com>
On 07/05/2015 19:01, Eric Blake wrote:
>> >
>> > + /* NBD errors should be universally equal to the corresponding
>> > + * errno values, check it here.
>> > + */
>> > + QEMU_BUILD_BUG_ON(EPERM != 1);
> And this is (probably not the first place) where qemu compilation would
> fail on Hurd. At any rate, I see no reason to hold up the patch on that
> ground.
Well, I can certainly add a backwards mapping.
Paolo
next prev parent reply other threads:[~2015-05-07 17:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:26 [Qemu-devel] [PATCH] qemu-nbd: return EROFS for discard on a read-only export Paolo Bonzini
2015-05-07 15:26 ` [Qemu-devel] [PATCH] qemu-nbd: only send a limited number of errno codes on the wire Paolo Bonzini
2015-05-07 17:01 ` Eric Blake
2015-05-07 17:06 ` Paolo Bonzini [this message]
2015-05-08 6:45 ` Markus Armbruster
2015-05-08 8:30 ` Paolo Bonzini
2015-05-08 9:32 ` Markus Armbruster
2015-05-08 9:40 ` Paolo Bonzini
2015-05-08 10:04 ` Markus Armbruster
2015-05-08 12:45 ` Max Reitz
2015-05-08 13:01 ` Max Reitz
2015-05-08 12:43 ` [Qemu-devel] [PATCH] qemu-nbd: return EROFS for discard on a read-only export Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554B9BA6.4050805@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).