From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPGC-0001YH-1S for qemu-devel@nongnu.org; Thu, 07 May 2015 13:06:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqPG8-0003TM-1X for qemu-devel@nongnu.org; Thu, 07 May 2015 13:06:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPG7-0003Sq-RE for qemu-devel@nongnu.org; Thu, 07 May 2015 13:06:51 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t47H6obL031381 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 7 May 2015 13:06:50 -0400 Message-ID: <554B9BA6.4050805@redhat.com> Date: Thu, 07 May 2015 19:06:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431012374-14113-1-git-send-email-pbonzini@redhat.com> <1431012374-14113-2-git-send-email-pbonzini@redhat.com> <554B9A67.60004@redhat.com> In-Reply-To: <554B9A67.60004@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: only send a limited number of errno codes on the wire List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com On 07/05/2015 19:01, Eric Blake wrote: >> > >> > + /* NBD errors should be universally equal to the corresponding >> > + * errno values, check it here. >> > + */ >> > + QEMU_BUILD_BUG_ON(EPERM != 1); > And this is (probably not the first place) where qemu compilation would > fail on Hurd. At any rate, I see no reason to hold up the patch on that > ground. Well, I can certainly add a backwards mapping. Paolo