From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPRn-0006KV-Ma for qemu-devel@nongnu.org; Thu, 07 May 2015 13:18:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqPRj-0007d7-Nu for qemu-devel@nongnu.org; Thu, 07 May 2015 13:18:55 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:36081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqPRj-0007cz-HM for qemu-devel@nongnu.org; Thu, 07 May 2015 13:18:51 -0400 Received: by wgiu9 with SMTP id u9so50302958wgi.3 for ; Thu, 07 May 2015 10:18:50 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <554B9E76.7060504@redhat.com> Date: Thu, 07 May 2015 19:18:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431017176-3301-1-git-send-email-quintela@redhat.com> <1431017176-3301-6-git-send-email-quintela@redhat.com> In-Reply-To: <1431017176-3301-6-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 05/16] arch_init: Alloc and free data struct for compression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: Yang Zhang , Liang Li On 07/05/2015 18:46, Juan Quintela wrote: > static CompressParam *comp_param; > static QemuThread *compress_threads; > +/* comp_done_cond is used to wake up the migration thread when > + * one of the compression threads has finished the compression. > + * comp_done_lock is used to co-work with comp_done_cond. > + */ > +static QemuMutex *comp_done_lock; > +static QemuCond *comp_done_cond; Can you please putr these (and the corresponding globals for decompression) in a struct? Paolo