From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqQ40-0007ED-N7 for qemu-devel@nongnu.org; Thu, 07 May 2015 13:58:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqQ3t-00067D-Dk for qemu-devel@nongnu.org; Thu, 07 May 2015 13:58:24 -0400 Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:34079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqQ3t-000675-9v for qemu-devel@nongnu.org; Thu, 07 May 2015 13:58:17 -0400 Received: by qcyk17 with SMTP id k17so25241026qcy.1 for ; Thu, 07 May 2015 10:58:16 -0700 (PDT) Sender: Richard Henderson Message-ID: <554BA7B5.10009@twiddle.net> Date: Thu, 07 May 2015 10:58:13 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1430926687-25875-1-git-send-email-a.rigo@virtualopensystems.com> <1430926687-25875-5-git-send-email-a.rigo@virtualopensystems.com> In-Reply-To: <1430926687-25875-5-git-send-email-a.rigo@virtualopensystems.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 4/5] tcg-op: create new TCG qemu_ldlink and qemu_stcond instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alvise Rigo , qemu-devel@nongnu.org Cc: mttcg@greensocs.com, jani.kokkonen@huawei.com, tech@virtualopensystems.com, claudio.fontana@huawei.com On 05/06/2015 08:38 AM, Alvise Rigo wrote: > +/* An output operand to return the StoreConditional result */ > +static void gen_stcond_i32(TCGOpcode opc, TCGv_i32 is_dirty, TCGv_i32 val, > + TCGv addr, TCGMemOp memop, TCGArg idx) > +{ > + tcg_gen_op5ii_i32(opc, is_dirty, val, addr, memop, idx); > +} This is the wrong way to go about this. I think you should merely add an EXCL bit to TCGMemOp, and add no new opcodes at all. r~