From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqgfS-0002qp-3o for qemu-devel@nongnu.org; Fri, 08 May 2015 07:42:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqgfR-0005jz-1A for qemu-devel@nongnu.org; Fri, 08 May 2015 07:42:10 -0400 Message-ID: <554CA100.4070400@redhat.com> Date: Fri, 08 May 2015 13:41:52 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431085109-19677-1-git-send-email-dimara@arrikto.com> <1431085109-19677-5-git-send-email-dimara@arrikto.com> In-Reply-To: <1431085109-19677-5-git-send-email-dimara@arrikto.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block: Include qemu-log.o in block-obj-y List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org On 08/05/2015 13:38, Dimitris Aragiorgis wrote: > Building the QEMU tools fails if we #define DEBUG_BLOCK inside > block/raw-posix.c. This happens because qemu-log.o is missing from > block-obj-y, which causes the link to fail. Fix this. > > Signed-off-by: Dimitris Aragiorgis Let's just remove DEBUG_BLOCK messages. There are only two and they only trigger for error cases. Paolo > --- > Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.objs b/Makefile.objs > index 28999d3..98f6e02 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -6,7 +6,7 @@ util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o > ####################################################################### > # block-obj-y is code used by both qemu system emulation and qemu-img > > -block-obj-y = async.o thread-pool.o > +block-obj-y = async.o thread-pool.o qemu-log.o > block-obj-y += nbd.o block.o blockjob.o > block-obj-y += main-loop.o iohandler.o qemu-timer.o > block-obj-$(CONFIG_POSIX) += aio-posix.o >