Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices

[Shannon Zhao <shannon.zhao@linaro.org>]

Hi Paolo,

Thanks for your reply. I just check whether I need to respin this 
patchset. I will look at the virtio-balloon.

Thanks,
Shannon

On 2015/5/8 14:53, Paolo Bonzini wrote:
> No, he is on vacation this week. Sorry for the delay!
>
> Of you are doing cleanups in virtio, perhaps you can look into using
> alias properties for virtio-balloon's QOM properties (for example the
> statistics). The code is currently using object_property_add and
> manually-written getters/setters.
>
> Thanks,
>
> Paolo
>
>
> -----Original Message-----
> From: Shannon Zhao [shannon.zhao@linaro.org]
> Received: venerdì, 08 mag 2015, 3:24
> To: qemu-devel@nongnu.org
> CC: peter.maydell@linaro.org, christoffer.dall@linaro.org,
> mst@redhat.com, pbonzini@redhat.com, peter.huangpeng@huawei.com,
> hangaohuai@huawei.com, zhaoshenglong@huawei.com
> Subject: Re: [PATCH 0/7] virtio: inline private qdev properties into
> virtio devices
>
>
>
> On 2015/4/29 23:24, Shannon Zhao wrote:
>  > The private qdev properties of virtio devices are only used by
>  > themselves. As Peter suggested and like what virtio-blk has done, we
>  > should move the private qdev properties into devices and don't expose
>  > them to avoid wrongly use.
>  >
>  > This patchset is based on following patchset which moves host features
>  > to backends.
>  > http://lists.gnu.org/archive/html/qemu-devel/2015-04/msg03785.html
>  >
>  > Shannon Zhao (7):
>  >   virtio-net: move qdev properties into virtio-net.c
>  >   virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES
>  >   virtio-scsi: move qdev properties into virtio-scsi.c
>  >   virtio-rng: move qdev properties into virtio-rng.c
>  >   virtio-serial-bus: move qdev properties into virtio-serial-bus.c
>  >   virtio-9p-device: move qdev properties into virtio-9p-device.c
>  >   vhost-scsi: move qdev properties into vhost-scsi.c
>
> Have any maintainer picked up these patches?
>
> --
> Shannon