From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqhQ8-0007xH-Jh for qemu-devel@nongnu.org; Fri, 08 May 2015 08:30:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqhQ5-0003GF-Bn for qemu-devel@nongnu.org; Fri, 08 May 2015 08:30:24 -0400 Received: from mail-pd0-f177.google.com ([209.85.192.177]:35073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqhQ5-0003G2-7D for qemu-devel@nongnu.org; Fri, 08 May 2015 08:30:21 -0400 Received: by pdbqd1 with SMTP id qd1so80449767pdb.2 for ; Fri, 08 May 2015 05:30:19 -0700 (PDT) Message-ID: <554CAC3E.5050902@linaro.org> Date: Fri, 08 May 2015 20:29:50 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1430321049-11859-1-git-send-email-shannon.zhao@linaro.org> <554C1023.20102@linaro.org> <1194329654.17445159.1431068023543.JavaMail.zimbra@zmail13.collab.prod.int.phx2.redhat.com> In-Reply-To: <1194329654.17445159.1431068023543.JavaMail.zimbra@zmail13.collab.prod.int.phx2.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/7] virtio: inline private qdev properties into virtio devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Hi Paolo, Thanks for your reply. I just check whether I need to respin this patchset. I will look at the virtio-balloon. Thanks, Shannon On 2015/5/8 14:53, Paolo Bonzini wrote: > No, he is on vacation this week. Sorry for the delay! > > Of you are doing cleanups in virtio, perhaps you can look into using > alias properties for virtio-balloon's QOM properties (for example the > statistics). The code is currently using object_property_add and > manually-written getters/setters. > > Thanks, > > Paolo > > > -----Original Message----- > From: Shannon Zhao [shannon.zhao@linaro.org] > Received: venerdì, 08 mag 2015, 3:24 > To: qemu-devel@nongnu.org > CC: peter.maydell@linaro.org, christoffer.dall@linaro.org, > mst@redhat.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, > hangaohuai@huawei.com, zhaoshenglong@huawei.com > Subject: Re: [PATCH 0/7] virtio: inline private qdev properties into > virtio devices > > > > On 2015/4/29 23:24, Shannon Zhao wrote: > > The private qdev properties of virtio devices are only used by > > themselves. As Peter suggested and like what virtio-blk has done, we > > should move the private qdev properties into devices and don't expose > > them to avoid wrongly use. > > > > This patchset is based on following patchset which moves host features > > to backends. > > http://lists.gnu.org/archive/html/qemu-devel/2015-04/msg03785.html > > > > Shannon Zhao (7): > > virtio-net: move qdev properties into virtio-net.c > > virtio-net.h: Remove unsed DEFINE_VIRTIO_NET_PROPERTIES > > virtio-scsi: move qdev properties into virtio-scsi.c > > virtio-rng: move qdev properties into virtio-rng.c > > virtio-serial-bus: move qdev properties into virtio-serial-bus.c > > virtio-9p-device: move qdev properties into virtio-9p-device.c > > vhost-scsi: move qdev properties into vhost-scsi.c > > Have any maintainer picked up these patches? > > -- > Shannon