From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yqhlp-0000yw-9Q
	for qemu-devel@nongnu.org; Fri, 08 May 2015 08:52:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yqhlk-0003IU-RW
	for qemu-devel@nongnu.org; Fri, 08 May 2015 08:52:49 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57222 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Yqhlk-0003HB-ME
	for qemu-devel@nongnu.org; Fri, 08 May 2015 08:52:44 -0400
Message-ID: <554CB19B.50302@suse.de>
Date: Fri, 08 May 2015 14:52:43 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1431089344-20350-1-git-send-email-pbonzini@redhat.com>
	<1431089344-20350-3-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1431089344-20350-3-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 2/9] apic_common: improve readability of
	apic_reset_common
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Denis V. Lunev" <den@openvz.org>

Am 08.05.2015 um 14:48 schrieb Paolo Bonzini:
> From: "Denis V. Lunev" <den@openvz.org>
>=20
> Replace call of cpu_is_bsp(s->cpu) which really returns
>     !!(s->apicbase & MSR_IA32_APICBASE_BSP)
> with directly collected value. Due to this the tracepoint
>   trace_cpu_get_apic_base((uint64_t)s->apicbase);
> will not be hit anymore in apic_reset_common.
>=20
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Andreas F=C3=83=C2=A4rber <afaerber@suse.de>

Unchanged...

> CC: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <1428414832-3104-1-git-send-email-den@openvz.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/intc/apic_common.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index d38d24b..d595d63 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -233,11 +233,10 @@ static void apic_reset_common(DeviceState *dev)
>  {
>      APICCommonState *s =3D APIC_COMMON(dev);
>      APICCommonClass *info =3D APIC_COMMON_GET_CLASS(s);
> -    bool bsp;
> +    uint32_t bsp;
> =20
> -    bsp =3D cpu_is_bsp(s->cpu);
> -    s->apicbase =3D APIC_DEFAULT_ADDRESS |
> -        (bsp ? MSR_IA32_APICBASE_BSP : 0) | MSR_IA32_APICBASE_ENABLE;
> +    bsp =3D s->apicbase & MSR_IA32_APICBASE_BSP;
> +    s->apicbase =3D APIC_DEFAULT_ADDRESS | bsp | MSR_IA32_APICBASE_ENA=
BLE;
> =20
>      s->vapic_paddr =3D 0;
>      info->vapic_base_update(s);
>=20


--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N=C3=BCrnberg)