From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqizs-0003q2-OO for qemu-devel@nongnu.org; Fri, 08 May 2015 10:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yqizn-00081D-Q8 for qemu-devel@nongnu.org; Fri, 08 May 2015 10:11:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqizn-00080e-IW for qemu-devel@nongnu.org; Fri, 08 May 2015 10:11:19 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t48EBIK7003568 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 8 May 2015 10:11:19 -0400 Message-ID: <554CC405.3090507@redhat.com> Date: Fri, 08 May 2015 08:11:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431088998-27721-1-git-send-email-quintela@redhat.com> <1431088998-27721-2-git-send-email-quintela@redhat.com> In-Reply-To: <1431088998-27721-2-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WJ9idS1Ov0jTdnLemH1tBA3WEuW7TaLhT" Subject: Re: [Qemu-devel] [PATCH 1/4] migration: move ram stuff to migration/ram List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WJ9idS1Ov0jTdnLemH1tBA3WEuW7TaLhT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/08/2015 06:43 AM, Juan Quintela wrote: > For historic reasons, ram migration have been on arch_init.c. Just s/have been on/has been in/ > split it into migration/ram.c, the same that happened with block.c. >=20 > There is only code movement, no changes altogether. >=20 > Signed-off-by: Juan Quintela > --- > MAINTAINERS | 1 - > Makefile.target | 1 + > arch_init.c | 1754 ++-------------------------------= -------- > include/migration/migration.h | 2 + > include/sysemu/arch_init.h | 1 - > migration/ram.c | 1681 +++++++++++++++++++++++++++++++++= ++++++ > trace-events | 2 +- > 7 files changed, 1747 insertions(+), 1695 deletions(-) > create mode 100644 migration/ram.c This diff is harder than necessary to read. It can be made smaller by using the --patience argument when creating the diff: $ git diff HEAD^ --patience --stat MAINTAINERS | 1 - Makefile.target | 1 + arch_init.c | 1630 --------------------------------------- include/migration/migration.h | 2 + include/sysemu/arch_init.h | 1 - migration/ram.c | 1681 +++++++++++++++++++++++++++++++++++++++++ trace-events | 2 +- 7 files changed, 1685 insertions(+), 1633 deletions(-) To make it permanent: $ git config diff.algorithm patience At any rate, here's how I reviewed: $ diff -u <(git diff HEAD^ | sed -n 's/^-//p') <(git diff HEAD^ | sed -n 's/^\+//p') You introduced a newline before mig_sleep_cpu(), and changed the text in the DPRINTF definition, but I can live with that. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WJ9idS1Ov0jTdnLemH1tBA3WEuW7TaLhT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVTMQFAAoJEKeha0olJ0Nq1w8H/iTJIH6A2Ql1XWwmHtqUTfdi EpwVwNPLGDzfGjFfwVJ+9zgEr60wZqPdy2qVpyjvlViabuKunlr/4N+b+rWMQ3UV klT1Qf9PWXJvDGBI0CMjhfMYhSZMqiPRAOdUPmGRCjTvEjtsh4i2bR9GQmk1xMFP btJ0/Hn1NaVJU7/atnhf3K2CLicgyHoBkiJY8j8K0Y+FcwntT7iae/fT1VyNnwTo uXhxFAlRucnmE4QLBLQF/wKg6MhvX20GdkV8a6tjyGULDGIMJZ/aXSmV65G8S1LP LD3OCNwwRblHWqIJMdGVHr9uenqFSVvxel++D6hOUUzT0fLOTXrCvCq6U1unKXo= =wXWV -----END PGP SIGNATURE----- --WJ9idS1Ov0jTdnLemH1tBA3WEuW7TaLhT--