From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqjG6-0000tt-Kz for qemu-devel@nongnu.org; Fri, 08 May 2015 10:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqjG2-0007Hi-AU for qemu-devel@nongnu.org; Fri, 08 May 2015 10:28:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34582 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqjG2-0007HV-4a for qemu-devel@nongnu.org; Fri, 08 May 2015 10:28:06 -0400 Message-ID: <554CC7F5.9090000@suse.de> Date: Fri, 08 May 2015 16:28:05 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1430476206-26034-1-git-send-email-berrange@redhat.com> <1430476206-26034-2-git-send-email-berrange@redhat.com> In-Reply-To: <1430476206-26034-2-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 1/7] qom: fix typename of 'policy' enum property in hostmem obj List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange: > The 'policy' property was being registered with a typename of > 'str', but it is in fact an enum of the 'HostMemPolicy' type. >=20 > Signed-off-by: Daniel P. Berrange > --- > backends/hostmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/backends/hostmem.c b/backends/hostmem.c > index b7b6cf8..f6db33c 100644 > --- a/backends/hostmem.c > +++ b/backends/hostmem.c > @@ -252,7 +252,7 @@ static void host_memory_backend_init(Object *obj) > object_property_add(obj, "host-nodes", "int", > host_memory_backend_get_host_nodes, > host_memory_backend_set_host_nodes, NULL, NULL= , NULL); > - object_property_add(obj, "policy", "str", > + object_property_add(obj, "policy", "HostMemPolicy", > host_memory_backend_get_policy, > host_memory_backend_set_policy, NULL, NULL, NU= LL); > } This patch is mislabeled IMO and none of my business, but cleanup is appreciated, Acked-by: Andreas F=E4rber Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)