From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqjYB-0007bI-7J for qemu-devel@nongnu.org; Fri, 08 May 2015 10:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqjY6-0005TT-7P for qemu-devel@nongnu.org; Fri, 08 May 2015 10:46:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35690 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqjY6-0005TN-0u for qemu-devel@nongnu.org; Fri, 08 May 2015 10:46:46 -0400 Message-ID: <554CCC52.2000909@suse.de> Date: Fri, 08 May 2015 16:46:42 +0200 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1430766598-8512-1-git-send-email-ehabkost@redhat.com> <20150508085145.39cc7e2b@redhat.com> <20150508143659.GI17796@thinpad.lan.raisama.net> In-Reply-To: <20150508143659.GI17796@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qmp: Add qom-path field to query-cpus command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mimu@linux.vnet.ibm.com, Igor Mammedov , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, Luiz Capitulino , borntraeger@de.ibm.com, agraf@suse.de, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, Paolo Bonzini , Jiri Denemark , david@gibson.dropbear.id.au Am 08.05.2015 um 16:36 schrieb Eduardo Habkost: > On Fri, May 08, 2015 at 08:51:45AM -0400, Luiz Capitulino wrote: >> On Mon, 4 May 2015 16:09:58 -0300 >> Eduardo Habkost wrote: >> >>> This will allow clients to query additional information directly usin= g >>> qom-get on the CPU objects. >> >> Eduardo, I'm not applying this patch this time because Eric's comments >> have to be addressed. >=20 > Yes, I will submit a new version later. If you just add the "since 2.4", Reviewed-by: Andreas F=E4rber As to qom-path vs. qom_path, I think we're using qom-path elsewhere in QMP or some of the scripts? I mainly care about the QOM properties being consistent, so choose as you see fit here. As for the reference to /machine/cpus/... I still think you're missing the point I made on the call and in my RFC. You shouldn't expect all CPUs to live in the same place like they do for PC or pSeries. Instead, I think exposing the same search-by-type functionality we have in the QOM C API in some QMP command (qom-search? qom-find? or qom-list?) will be much better than trying to "equalize" the composition tree for the benefit of libvirt accessing it by fixed paths. Therefore my abstract socket type, and I would propose to do the same thing for the core. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)