From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YqkCw-0001c9-VA for qemu-devel@nongnu.org; Fri, 08 May 2015 11:28:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YqkCw-0002wq-7S for qemu-devel@nongnu.org; Fri, 08 May 2015 11:28:58 -0400 Message-ID: <554CD5FC.8090802@redhat.com> Date: Fri, 08 May 2015 17:27:56 +0200 From: Max Reitz MIME-Version: 1.0 References: <119060b56f474e32cbbe9327303a8a690f3f24e0.1430919406.git.berto@igalia.com> In-Reply-To: <119060b56f474e32cbbe9327303a8a690f3f24e0.1430919406.git.berto@igalia.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/7] qcow2: remove qcow2_cache_find_entry_to_replace() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org On 06.05.2015 15:39, Alberto Garcia wrote: > A cache miss means that the whole array was traversed and the entry > we were looking for was not found, so there's no need to traverse it > again in order to select an entry to replace. > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cache.c | 45 ++++++++++++++++----------------------------- > 1 file changed, 16 insertions(+), 29 deletions(-) Reviewed-by: Max Reitz