From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqlz8-0002U7-OD for qemu-devel@nongnu.org; Fri, 08 May 2015 13:22:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yqlz3-0004dp-PG for qemu-devel@nongnu.org; Fri, 08 May 2015 13:22:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42236 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yqlz3-0004cj-Jv for qemu-devel@nongnu.org; Fri, 08 May 2015 13:22:45 -0400 Message-ID: <554CF0E4.7050606@suse.de> Date: Fri, 08 May 2015 19:22:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1430476206-26034-1-git-send-email-berrange@redhat.com> <1430476206-26034-5-git-send-email-berrange@redhat.com> <554CEE19.2010704@suse.de> <554CF001.9000505@redhat.com> In-Reply-To: <554CF001.9000505@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/7] qom: add object_new_propv / object_new_proplist constructors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 08.05.2015 um 19:18 schrieb Paolo Bonzini: > On 08/05/2015 19:10, Andreas F=E4rber wrote: >>> Error *err =3D NULL; >>> Object *obj; >>> obj =3D object_new_propv(TYPE_MEMORY_BACKEND_FILE, >>> "/objects", >> >> This is not an Object*. ;) I like it better as it's implemented below, >> but cf. above for mixing this Error**-ing operation with object_new(). >=20 > Right, this was my main request on review Hm, didn't make it to the list then...? Only the one reply to 0/7. Andreas > and I had fixed up the commit > message in the pull request. >=20 > I'm certainly okay with a separate object_set_props function (better: > object_parse_props) and object_parse_propv for the va_list case. >=20 > Paolo --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)