From: Eric Blake <eblake@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>,
qemu-devl <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Cc: Gonglei <arei.gonglei@huawei.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set bits in hbitmap
Date: Fri, 08 May 2015 14:23:15 -0600 [thread overview]
Message-ID: <554D1B33.4010108@redhat.com> (raw)
In-Reply-To: <554C0D86.1010705@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
On 05/07/2015 07:12 PM, Wen Congyang wrote:
> The function bdrv_clear_dirty_bitmap() is updated to use
> faster hbitmap_reset_all() call.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block.c | 2 +-
> include/qemu/hbitmap.h | 8 ++++++++
> tests/test-hbitmap.c | 38 ++++++++++++++++++++++++++++++++++++++
> util/hbitmap.c | 13 +++++++++++++
> 4 files changed, 60 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
> +void hbitmap_reset_all(HBitmap *hb)
> +{
> + unsigned int i;
> +
> + /* Same as hbitmap_alloc() except memset() */
maybe s/except memset()/except for memset() instead of malloc()/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-08 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 1:12 [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set bits in hbitmap Wen Congyang
2015-05-08 20:23 ` Eric Blake [this message]
2015-05-11 15:06 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554D1B33.4010108@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).