From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47018)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Yqonu-0002ER-Uj
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:23:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Yqonr-0003tq-P3
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:23:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38676)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1Yqonr-0003tC-H6
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:23:23 -0400
Message-ID: <554D1B33.4010108@redhat.com>
Date: Fri, 08 May 2015 14:23:15 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <554C0D86.1010705@cn.fujitsu.com>
In-Reply-To: <554C0D86.1010705@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="Kk1LMcreBHOU7vkwdJwfIotq866ggNTBK"
Subject: Re: [Qemu-devel] [PATCH] util/hbitmap: Add an API to reset all set
 bits in hbitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>, qemu-devl <qemu-devel@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Cc: Gonglei <arei.gonglei@huawei.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--Kk1LMcreBHOU7vkwdJwfIotq866ggNTBK
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/07/2015 07:12 PM, Wen Congyang wrote:
> The function bdrv_clear_dirty_bitmap() is updated to use
> faster hbitmap_reset_all() call.
>=20
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block.c                |  2 +-
>  include/qemu/hbitmap.h |  8 ++++++++
>  tests/test-hbitmap.c   | 38 ++++++++++++++++++++++++++++++++++++++
>  util/hbitmap.c         | 13 +++++++++++++
>  4 files changed, 60 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>


> +void hbitmap_reset_all(HBitmap *hb)
> +{
> +    unsigned int i;
> +
> +    /* Same as hbitmap_alloc() except memset() */

maybe s/except memset()/except for memset() instead of malloc()/

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--Kk1LMcreBHOU7vkwdJwfIotq866ggNTBK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVTRszAAoJEKeha0olJ0NqLGcH/3hJMqHoOkDdRbRvhNeCfivE
YwMR9yw/o8ySrcUb2/2fqxdWJex6p7BFeHZ6YAGvTlLDhVT0iYe0i2efLbNCDuHX
qiOPT/az3EaNI/O+oQk+r7VxgSjIv+DOWEWd3w3wKIXTg8qzv18SQBq1GyZT20u5
UxbgWjEoeMIBxtgNsn/+/V5zQMimxje5dhhbGBNL9nC8iCKLWnaMUK8fxRTYS88L
/VrxajIyp3mfnJTtrxbWLEqhoYZHrZWeNll53Le2v4DPNY9+n1TpOwzXum0gvkfs
v+j7cxug/XbSUejOTS+3VmUOWoqnU/sFYvGKvgiNr7JVo//1dD8Q4wjq/GdghXM=
=++kF
-----END PGP SIGNATURE-----

--Kk1LMcreBHOU7vkwdJwfIotq866ggNTBK--