From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1YqpN6-0003DJ-2H
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:59:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1YqpN2-0007lI-2r
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:59:48 -0400
Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:34199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1YqpN1-0007ip-UE
	for qemu-devel@nongnu.org; Fri, 08 May 2015 16:59:44 -0400
Received: by obfe9 with SMTP id e9so64280469obf.1
	for <qemu-devel@nongnu.org>; Fri, 08 May 2015 13:59:42 -0700 (PDT)
Sender: Corey Minyard <tcminyard@gmail.com>
Message-ID: <554D23BC.3040300@acm.org>
Date: Fri, 08 May 2015 15:59:40 -0500
From: Corey Minyard <minyard@acm.org>
MIME-Version: 1.0
References: <1429829878-26862-1-git-send-email-minyard@acm.org>	<1429829878-26862-3-git-send-email-minyard@acm.org>
	<20150426110026-mutt-send-email-mst@redhat.com>
	<553D1A7F.8080803@redhat.com>
In-Reply-To: <553D1A7F.8080803@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure
Reply-To: minyard@acm.org
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org

On 04/26/2015 12:03 PM, Paolo Bonzini wrote:
>
> On 26/04/2015 11:05, Michael S. Tsirkin wrote:
>>> +
>>> +#define FW_CFG_IPMI_INTERFACE   0x30
>>> +#define FW_CFG_IPMI_BASE_ADDR   0x31
>>> +#define FW_CFG_IPMI_REG_SPACE   0x32
>>> +#define FW_CFG_IPMI_REG_SPACING 0x33
>>> +#define FW_CFG_IPMI_SLAVE_ADDR  0x34
>>> +#define FW_CFG_IPMI_IRQ         0x35
>>> +#define FW_CFG_IPMI_VERSION     0x36
>>> +
>>> +#define FW_CFG_MAX_ENTRY        (FW_CFG_IPMI_VERSION + 1)
> Also, what is this used for?  I haven't seen firmware patches, maybe
> it's obsoleted by SMBIOS support in QEMU?
>
> Paolo

Finally back on this.  This is bogus, it was left over from something
else, and I missed it because it was at the end of the file.

-corey