From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrRqr-0000r1-TM for qemu-devel@nongnu.org; Sun, 10 May 2015 10:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrRqq-0007rb-Vn for qemu-devel@nongnu.org; Sun, 10 May 2015 10:05:05 -0400 Message-ID: <554F6587.5060909@redhat.com> Date: Sun, 10 May 2015 16:04:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431107242-31947-1-git-send-email-dimara@arrikto.com> In-Reply-To: <1431107242-31947-1-git-send-email-dimara@arrikto.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] Some fixes related to scsi-generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org On 08/05/2015 19:47, Dimitris Aragiorgis wrote: > Hi all, > > These four patches make slight changes to the way QEMU handles SCSI > generic devices to fix a number of small problems. > > I am sending them against the master branch, since I don't know if they > can be considered bugfixes. > > Thanks, > dimara > > v2: > * remove duplicate check for sg inside iscsi_co_flush() > * remove DEBUG_BLOCK_PRINT in block/raw-posix.c > * use DPRINTF for debugging in block/raw-posix.c > > PS: Paolo suggested to use a tracepoint inside hdev_is_sg() but I chose DPRINTF > instead. It would make sense to add a tracepoint for bdrv_is_sg() (just like > most bdrv_* commands) but this is too much for now since it just returns the > bs->sg flag (and is not an actual driver function). If you insist I'll change > it in v3. > > Dimitris Aragiorgis (5): > block: Use bdrv_is_sg() everywhere > Fix migration in case of scsi-generic > raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT > raw-posix: Use DPRINTF for DEBUG_FLOPPY > raw-posix: Introduce hdev_is_sg() > > block.c | 6 ++--- > block/io.c | 2 +- > block/iscsi.c | 4 --- > block/raw-posix.c | 75 +++++++++++++++++++++++++++++------------------------ > 4 files changed, 45 insertions(+), 42 deletions(-) > I am okay with the debug printf, even though the problem with debug printfs is that no one uses them and they bitrot. Reviewed-by: Paolo Bonzini Paolo