From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrkh0-0006L3-0e for qemu-devel@nongnu.org; Mon, 11 May 2015 06:12:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrkgv-0000F1-0K for qemu-devel@nongnu.org; Mon, 11 May 2015 06:12:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrkgu-0000Ev-RZ for qemu-devel@nongnu.org; Mon, 11 May 2015 06:12:04 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 6A76C91E8C for ; Mon, 11 May 2015 10:12:04 +0000 (UTC) Message-ID: <5550806F.6070909@redhat.com> Date: Mon, 11 May 2015 12:11:59 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431322734-12520-1-git-send-email-mrezanin@redhat.com> <55506AE4.8030902@redhat.com> <20150511093643.GB26672@lws.brq.redhat.com> In-Reply-To: <20150511093643.GB26672@lws.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv2] parallel: Allow to disable CONFIG_PARALLEL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miroslav Rezanina Cc: thuth@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 11/05/2015 11:36, Miroslav Rezanina wrote: >> > This patch will make "-parallel" a nop. The right thing to do is to >> > fail startup whenever -parallel is passed and CONFIG_PARALLEL is disabled. >> > > This was original behavior before 07dc788. Intention of this patch is to > make qemu buildable with CONFIG_PARALLEL disabled. Understood, but in the meanwhile Markus wrote commit 4bc6a3e (parallel: parallel_hds_isa_init() shouldn't fail, 2015-02-04), and you should preserve the logic of that commit. >> > You can move parallel_hds_isa_init and parallel_init to >> > hw/isa/isa-bus.c, or to a new file hw/isa/isa-devices.c. >> > > Moving functions will cause abort with "Unknown device" error. This is the right behavior that we want: exit QEMU, not go on silently without the parallel port. If you do not like the abort, you should revert commit 4bc6a3e, and make parallel_hds_isa_init check for failure of parallel_init. But for me it's okay to just let it abort. Paolo