From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrkjR-0000di-5q for qemu-devel@nongnu.org; Mon, 11 May 2015 06:14:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrkjL-00015a-3h for qemu-devel@nongnu.org; Mon, 11 May 2015 06:14:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrkjK-00015C-TL for qemu-devel@nongnu.org; Mon, 11 May 2015 06:14:35 -0400 Message-ID: <555080FE.3060607@redhat.com> Date: Mon, 11 May 2015 12:14:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431336847-4104-1-git-send-email-shannon.zhao@linaro.org> In-Reply-To: <1431336847-4104-1-git-send-email-shannon.zhao@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] virtio-balloon: use alias property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: shannon.zhao@linaro.org, qemu-devel@nongnu.org, peter.maydell@linaro.org, cornelia.huck@de.ibm.com, mst@redhat.com Cc: hangaohuai@huawei.com, peter.huangpeng@huawei.com, christoffer.dall@linaro.org, zhaoshenglong@huawei.com On 11/05/2015 11:34, shannon.zhao@linaro.org wrote: > From: Shannon Zhao > > The wrappers of virtio-balloon are using object_property_add to add > properties and all have their own getters/setters which are duplicate of > those in virtio-balloon device. So this patchset uses > object_property_add_alias for these properties as Paolo suggested. > > Shannon Zhao (3): > hw/virtio/virtio-balloon: move adding property to > virtio_balloon_instance_init > hw/virtio/virtio-pci: use alias property for virtio-balloon-pci > hw/s390x/virtio-ccw: use alias property for virtio-balloon-ccw > > hw/s390x/virtio-ccw.c | 39 ++++++--------------------------------- > hw/virtio/virtio-balloon.c | 22 ++++++++++++++-------- > hw/virtio/virtio-pci.c | 40 ++++++---------------------------------- > 3 files changed, 26 insertions(+), 75 deletions(-) > Nice. Reviewed-by: Paolo Bonzini