From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yrkpn-0006sN-Rk for qemu-devel@nongnu.org; Mon, 11 May 2015 06:21:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yrkpn-0003cq-1u for qemu-devel@nongnu.org; Mon, 11 May 2015 06:21:15 -0400 Message-ID: <55508290.7050009@redhat.com> Date: Mon, 11 May 2015 12:21:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1431107242-31947-1-git-send-email-dimara@arrikto.com> <1431107242-31947-4-git-send-email-dimara@arrikto.com> <20150511101644.GE4962@noname.redhat.com> In-Reply-To: <20150511101644.GE4962@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/5] raw-posix: DPRINTF instead of DEBUG_BLOCK_PRINT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Dimitris Aragiorgis Cc: stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On 11/05/2015 12:16, Kevin Wolf wrote: > Am 08.05.2015 um 19:47 hat Dimitris Aragiorgis geschrieben: >> > Building the QEMU tools fails if we #define DEBUG_BLOCK inside >> > block/raw-posix.c. Here instead of adding qemu-log.o in block-obj-y >> > so that DEBUG_BLOCK_PRINT can be used, we substitute the latter with >> > a simple DPRINTF(). >> > >> > Signed-off-by: Dimitris Aragiorgis > > Why is this better than linking in qemu-log.o? Speaking as the one who suggested this, because no one else uses qemu-log in the backends, and because qemu_log is tied to command-line processing that the tools do not do (qemu_set_log, qemu_set_log_filename). Paolo