From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrnVp-0001KK-GT for qemu-devel@nongnu.org; Mon, 11 May 2015 09:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrnVl-0004NX-Js for qemu-devel@nongnu.org; Mon, 11 May 2015 09:12:49 -0400 Message-ID: <5550AAC3.5060601@redhat.com> Date: Mon, 11 May 2015 15:12:35 +0200 From: Max Reitz MIME-Version: 1.0 References: <7714974c1f563a85daa35a64036dffe06442370d.1431348770.git.berto@igalia.com> In-Reply-To: <7714974c1f563a85daa35a64036dffe06442370d.1431348770.git.berto@igalia.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8] qcow2: make qcow2_cache_put() a void function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 11.05.2015 14:54, Alberto Garcia wrote: > This function never receives an invalid table pointer, so we can make > it void and remove all the error checking code. > > Signed-off-by: Alberto Garcia > Reviewed-by: Stefan Hajnoczi > --- > block/qcow2-cache.c | 7 +------ > block/qcow2-cluster.c | 50 ++++++++++---------------------------------------- > block/qcow2-refcount.c | 29 +++++------------------------ > block/qcow2.h | 2 +- > 4 files changed, 17 insertions(+), 71 deletions(-) Reviewed-by: Max Reitz