Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

[Paolo Bonzini <pbonzini@redhat.com>]

On 08/05/2015 23:16, Corey Minyard wrote:
>>> >> +    ipmi->intf = intf;
>>> >> +    object_property_add_child(OBJECT(isadev), "intf", OBJECT(intf), errp);
>>> >> +    if (*errp) {
>>> >> +        return;
>>> >> +    }
>>> >> +    object_property_add_child(OBJECT(isadev), "bmc", OBJECT(bmc), errp);
>>> >> +    if (*errp) {
>>> >> +        return;
>>> >> +    }
>>> >> +
>> > Should the created object be destroyed before return?
> Returning an error from the realize here appears to result in an error
> being printed and qemu being terminated, as far as I can tell.  So it
> shouldn't matter here, right?

I would just use &error_abort and ignore error handling.

Paolo