From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56322)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Yroaf-0001nc-Ed
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:21:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YroaY-00057A-LT
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:21:53 -0400
Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:34928)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YroaY-000570-Dr
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:21:46 -0400
Received: by wgbhc8 with SMTP id hc8so29579210wgb.2
	for <qemu-devel@nongnu.org>; Mon, 11 May 2015 07:21:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5550BAF6.40107@redhat.com>
Date: Mon, 11 May 2015 16:21:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1429829878-26862-1-git-send-email-minyard@acm.org>	<1429829878-26862-3-git-send-email-minyard@acm.org>	<20150426105502-mutt-send-email-mst@redhat.com>
	<554D2791.6070401@acm.org>
In-Reply-To: <554D2791.6070401@acm.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Corey Minyard <cminyard@mvista.com>, andreas.faerber@web.de, qemu-devel@nongnu.org



On 08/05/2015 23:16, Corey Minyard wrote:
>>> >> +    ipmi->intf = intf;
>>> >> +    object_property_add_child(OBJECT(isadev), "intf", OBJECT(intf), errp);
>>> >> +    if (*errp) {
>>> >> +        return;
>>> >> +    }
>>> >> +    object_property_add_child(OBJECT(isadev), "bmc", OBJECT(bmc), errp);
>>> >> +    if (*errp) {
>>> >> +        return;
>>> >> +    }
>>> >> +
>> > Should the created object be destroyed before return?
> Returning an error from the realize here appears to result in an error
> being printed and qemu being terminated, as far as I can tell.  So it
> shouldn't matter here, right?

I would just use &error_abort and ignore error handling.

Paolo