From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34425)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YroyR-0000uW-Sp
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:46:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YroyN-0005U5-Lr
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:46:27 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:33172)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YroyN-0005Tx-F7
	for qemu-devel@nongnu.org; Mon, 11 May 2015 10:46:23 -0400
Received: by wgin8 with SMTP id n8so130692072wgi.0
	for <qemu-devel@nongnu.org>; Mon, 11 May 2015 07:46:22 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5550C0BA.9000700@redhat.com>
Date: Mon, 11 May 2015 16:46:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1431200693.git.crosthwaite.peter@gmail.com>
	<568911201d01acf373f834af21c5d193dd6d8f2f.1431200693.git.crosthwaite.peter@gmail.com>
In-Reply-To: <568911201d01acf373f834af21c5d193dd6d8f2f.1431200693.git.crosthwaite.peter@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/7] disas: QOMify target specific setup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgari@xilinx.com, claudio.fontana@huawei.com, edgar.iglesias@gmail.com, rth@twiddle.net



On 09/05/2015 22:11, Peter Crosthwaite wrote:
> @@ -198,6 +199,8 @@ static int print_insn_od_target(bfd_vma pc, disassemble_info *info)
>  void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>                    target_ulong size, int flags)
>  {
> +    CPUState *cpu = ENV_GET_CPU(env);
> +    CPUClass *cc = CPU_GET_CLASS(cpu);
>      target_ulong pc;
>      int count;
>      CPUDebug s;
> @@ -215,6 +218,11 @@ void target_disas(FILE *out, CPUArchState *env, target_ulong code,
>  #else
>      s.info.endian = BFD_ENDIAN_LITTLE;
>  #endif
> +
> +    if (cc->disas_set_info) {
> +        cc->disas_set_info(cpu, &s.info);
> +    }
> +
>  #if defined(TARGET_I386)

Perhaps pass down the flags too?

Paolo