From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrpFR-0001L3-B8 for qemu-devel@nongnu.org; Mon, 11 May 2015 11:04:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrpFN-0003a0-SU for qemu-devel@nongnu.org; Mon, 11 May 2015 11:04:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrpFN-0003Zl-JU for qemu-devel@nongnu.org; Mon, 11 May 2015 11:03:57 -0400 Message-ID: <5550C4BD.6030500@redhat.com> Date: Mon, 11 May 2015 09:03:25 -0600 From: Eric Blake MIME-Version: 1.0 References: <1431329108-2605-1-git-send-email-mst@redhat.com> <1431329108-2605-24-git-send-email-mst@redhat.com> In-Reply-To: <1431329108-2605-24-git-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IE5xfnK4AQ9q9JL2j549KEEwPGFswLCeg" Subject: Re: [Qemu-devel] [PULL 23/28] qmp-event: add event notification for memory hot unplug error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Zhu Guihua , Michael Roth , Igor Mammedov , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IE5xfnK4AQ9q9JL2j549KEEwPGFswLCeg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/11/2015 06:48 AM, Michael S. Tsirkin wrote: > From: Zhu Guihua >=20 > When memory hot unplug fails, this patch adds support to send > QMP event to notify mgmt about this failure. >=20 > Reviewed-by: Igor Mammedov > Signed-off-by: Zhu Guihua > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > qapi/event.json | 14 ++++++++++++++ > hw/acpi/memory_hotplug.c | 10 +++++++++- > docs/qmp/qmp-events.txt | 17 +++++++++++++++++ > trace-events | 1 + > 4 files changed, 41 insertions(+), 1 deletion(-) I missed reviewing this earlier; and since it is now in a PULL request, you'll need a followup patch: > + > +## > +# @MEM_UNPLUG_ERROR > +# > +# Emitted when memory hot unplug error occurs. > +# > +# @device: device name > +# > +# @msg: Informative message > +# > +# Since: 2.4 > +## > +{ 'event': 'MEM_UNPLUG_ERROR', The name here... > +++ b/docs/qmp/qmp-events.txt > @@ -226,6 +226,23 @@ Example: > { "event": "GUEST_PANICKED", > "data": { "action": "pause" } } > =20 > +MEM_HOT_UNPLUG_ERROR =2E..needs to be the same one used here. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IE5xfnK4AQ9q9JL2j549KEEwPGFswLCeg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVUMS9AAoJEKeha0olJ0NqB0gIAKdKZSK21SEVgiAvTt6KHfYV /QjmRfK6sNL07dL0p9yS0w+O5dwbBqXptiEUvQhySoqD9smEB0/pA7yXsdTCM327 RJL+WXf1XtJJKOuUfpynqbXHz75f89tV4ANCwHlbsLtC+oanEm7c/3FhCfiFhMfZ VVkguS59UJPp8+mRYIY0bQcprle2cUtXurKOStN7PHMqLcFz5IydmbXwhgVJGIXg hz8XLDFZqL25ynK7uKOyhKyTVaqo3SkKpjvnSFqzxFmtg1TMFiX6SEY1CHiAgoSg fzok7MvRHOEtosypKdhHJdbrdPMAcF/MoEkWHUKS8f4ZxjXUKos3vT3lITzdjXY= =yThX -----END PGP SIGNATURE----- --IE5xfnK4AQ9q9JL2j549KEEwPGFswLCeg--