From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page
Date: Mon, 11 May 2015 09:32:37 -0600 [thread overview]
Message-ID: <5550CB95.8090705@redhat.com> (raw)
In-Reply-To: <20150511145437.GJ16270@stefanha-thinkpad.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 762 bytes --]
On 05/11/2015 08:54 AM, Stefan Hajnoczi wrote:
> On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote:
>> @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
>>
>> raw_probe_alignment(bs, s->fd, errp);
>> bs->bl.min_mem_alignment = s->buf_align;
>> - bs->bl.opt_mem_alignment = s->buf_align;
>> + if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment)
>> + bs->bl.opt_mem_alignment = bs->bl.min_mem_alignment;
>
> QEMU coding style uses {} even when the if statement body is only one
> line.
scripts/checkpatch.pl helps you check for this and other style issues.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-05-11 15:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 13:42 [Qemu-devel] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Denis V. Lunev
2015-05-04 13:42 ` [Qemu-devel] [PATCH 1/2] block: minimal bounce buffer alignment Denis V. Lunev
2015-05-04 13:42 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-11 14:54 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2015-05-11 15:32 ` Eric Blake [this message]
2015-05-11 15:40 ` Denis V. Lunev
2015-05-11 15:08 ` [Qemu-devel] [Qemu-block] [PATCH v5 0/2] block: enforce minimal 4096 alignment in qemu_blockalign Stefan Hajnoczi
2015-05-11 16:07 ` Denis V. Lunev
2015-05-11 16:38 ` Denis V. Lunev
2015-05-11 16:47 ` Denis V. Lunev
2015-05-12 10:01 ` Stefan Hajnoczi
2015-05-12 10:19 ` Denis V. Lunev
2015-05-12 10:46 ` Paolo Bonzini
2015-05-13 15:43 ` Stefan Hajnoczi
2015-05-13 16:46 ` Denis V. Lunev
2015-05-29 16:43 ` [Qemu-devel] " Paolo Bonzini
2015-06-01 10:34 ` Dmitry Monakhov
2015-06-01 10:41 ` Paolo Bonzini
2015-06-01 11:16 ` Dmitry Monakhov
2015-06-01 11:26 ` Paolo Bonzini
2015-06-01 11:57 ` Dmitry Monakhov
2015-05-14 9:13 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2015-05-12 5:47 [Qemu-devel] [PATCH v6 " Denis V. Lunev
2015-05-12 5:47 ` [Qemu-devel] [PATCH 2/2] block: align bounce buffers to page Denis V. Lunev
2015-05-12 10:27 ` Kevin Wolf
2015-05-12 10:36 ` [Qemu-devel] [Qemu-block] " Denis V. Lunev
2015-05-12 13:08 ` Kevin Wolf
2015-05-12 13:13 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550CB95.8090705@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).